[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[taler-exchange] 75/152: clarify with/without wire fee issue, sanity che
From: |
gnunet |
Subject: |
[taler-exchange] 75/152: clarify with/without wire fee issue, sanity checks on currencies |
Date: |
Sun, 05 Jul 2020 20:47:11 +0200 |
This is an automated email from the git hooks/post-receive script.
grothoff pushed a commit to branch master
in repository exchange.
commit 48d4690fbd0576e900332dcbfb285d0537091abf
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Tue Jun 23 10:30:31 2020 +0200
clarify with/without wire fee issue, sanity checks on currencies
---
src/include/taler_exchange_service.h | 2 +-
src/lib/exchange_api_transfers_get.c | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/include/taler_exchange_service.h
b/src/include/taler_exchange_service.h
index 07998702..e61a07c9 100644
--- a/src/include/taler_exchange_service.h
+++ b/src/include/taler_exchange_service.h
@@ -1611,7 +1611,7 @@ struct TALER_EXCHANGE_TransferData
struct GNUNET_TIME_Absolute execution_time;
/**
- * amount of the wire transfer; FIXME: total wired (without fee), or
including @a wire_fee?
+ * Actual amount of the wire transfer, excluding the wire fee.
*/
struct TALER_Amount total_amount;
diff --git a/src/lib/exchange_api_transfers_get.c
b/src/lib/exchange_api_transfers_get.c
index dd9b6446..6b5bba8e 100644
--- a/src/lib/exchange_api_transfers_get.c
+++ b/src/lib/exchange_api_transfers_get.c
@@ -155,6 +155,12 @@ check_transfers_get_response_ok (
GNUNET_JSON_parse (detail_j,
spec_detail,
NULL, NULL)) ||
+ (GNUNET_OK !=
+ TALER_amount_cmp_currency (&total_expected,
+ &detail->coin_value)) ||
+ (GNUNET_OK !=
+ TALER_amount_cmp_currency (&total_expected,
+ &detail->coin_fee)) ||
(0 >
TALER_amount_add (&total_expected,
&total_expected,
--
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.
- [taler-exchange] 54/152: ecs, (continued)
- [taler-exchange] 54/152: ecs, gnunet, 2020/07/05
- [taler-exchange] 56/152: update ECs, gnunet, 2020/07/05
- [taler-exchange] 61/152: bringing gana up to date so uncrustify accepts taler_error_codes.h, gnunet, 2020/07/05
- [taler-exchange] 59/152: fixed endianness in taler_sq_lib, gnunet, 2020/07/05
- [taler-exchange] 57/152: created taler_sq_lib, gnunet, 2020/07/05
- [taler-exchange] 62/152: do init submodules, gnunet, 2020/07/05
- [taler-exchange] 68/152: synchronize with latest GANA, gnunet, 2020/07/05
- [taler-exchange] 66/152: moved yna to exchange, gnunet, 2020/07/05
- [taler-exchange] 69/152: TALER_TESTING_cmd_admin_add_incoming_with_ref finds reserve_pub if reserve_priv doesn't exist, gnunet, 2020/07/05
- [taler-exchange] 72/152: Merge branch 'protocolv8' of git+ssh://git.taler.net/exchange into protocolv8, gnunet, 2020/07/05
- [taler-exchange] 75/152: clarify with/without wire fee issue, sanity checks on currencies,
gnunet <=
- [taler-exchange] 78/152: fix #6236, gnunet, 2020/07/05
- [taler-exchange] 74/152: traits for int64_t and json_t, gnunet, 2020/07/05
- [taler-exchange] 50/152: more ecs, gnunet, 2020/07/05
- [taler-exchange] 49/152: use unregister, gnunet, 2020/07/05
- [taler-exchange] 53/152: fix auditor drop, gnunet, 2020/07/05
- [taler-exchange] 55/152: more ECs, gnunet, 2020/07/05
- [taler-exchange] 58/152: implemented the other functions for taler_sq_lib, gnunet, 2020/07/05
- [taler-exchange] 60/152: taler_error_codes.h auto generated from gnunet/gana.git as a submodule, gnunet, 2020/07/05
- [taler-exchange] 31/152: more ecs, gnunet, 2020/07/05
- [taler-exchange] 34/152: ign, gnunet, 2020/07/05