[taler-exchange] 139/152: clarify with/without wire fee issue, sanity checks on currencies

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

commit dc9f41a7940a540df9d6f9a1d1b3a01c96176b11
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Tue Jun 23 10:30:31 2020 +0200

    clarify with/without wire fee issue, sanity checks on currencies
---
 src/include/taler_exchange_service.h | 2 +-
 src/lib/exchange_api_transfers_get.c | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/include/taler_exchange_service.h 
b/src/include/taler_exchange_service.h
index 07998702..e61a07c9 100644
--- a/src/include/taler_exchange_service.h
+++ b/src/include/taler_exchange_service.h
@@ -1611,7 +1611,7 @@ struct TALER_EXCHANGE_TransferData
   struct GNUNET_TIME_Absolute execution_time;
 
   /**
-   * amount of the wire transfer; FIXME: total wired (without fee), or 
including @a wire_fee?
+   * Actual amount of the wire transfer, excluding the wire fee.
    */
   struct TALER_Amount total_amount;
 
diff --git a/src/lib/exchange_api_transfers_get.c 
b/src/lib/exchange_api_transfers_get.c
index dd9b6446..6b5bba8e 100644
--- a/src/lib/exchange_api_transfers_get.c
+++ b/src/lib/exchange_api_transfers_get.c
@@ -155,6 +155,12 @@ check_transfers_get_response_ok (
             GNUNET_JSON_parse (detail_j,
                                spec_detail,
                                NULL, NULL)) ||
+           (GNUNET_OK !=
+            TALER_amount_cmp_currency (&total_expected,
+                                       &detail->coin_value)) ||
+           (GNUNET_OK !=
+            TALER_amount_cmp_currency (&total_expected,
+                                       &detail->coin_fee)) ||
            (0 >
             TALER_amount_add (&total_expected,
                               &total_expected,

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.