[taler-merchant] branch master updated: explain #6854: the break was bogus

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository merchant.

The following commit(s) were added to refs/heads/master by this push:
     new dfdd322c explain #6854: the break was bogus
dfdd322c is described below

commit dfdd322c1fd4d35926fd0cff5aaf7475fd6e232c
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Tue May 11 22:47:23 2021 +0200

    explain #6854: the break was bogus
---
 .../taler-merchant-httpd_private-post-transfers.c        | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/src/backend/taler-merchant-httpd_private-post-transfers.c 
b/src/backend/taler-merchant-httpd_private-post-transfers.c
index 52f12a16..26db9118 100644
--- a/src/backend/taler-merchant-httpd_private-post-transfers.c
+++ b/src/backend/taler-merchant-httpd_private-post-transfers.c
@@ -976,6 +976,8 @@ TMH_private_post_transfers (const struct TMH_RequestHandler 
*rh,
         uint64_t account_serial;
 
         /* Make sure the bank account is configured. */
+        GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+                    "Transfer is not yet known\n");
         qs = TMH_db->lookup_account (TMH_db->cls,
                                      ptc->hc->instance->settings.id,
                                      ptc->payto_uri,
@@ -1026,9 +1028,11 @@ TMH_private_post_transfers (const struct 
TMH_RequestHandler *rh,
                                              TALER_EC_GENERIC_DB_STORE_FAILED,
                                              "transfer");
         case GNUNET_DB_STATUS_SUCCESS_NO_RESULTS:
-          /* insert failed due to UNIQUE violation, after
-             the earlier lookup failed? very strange! */
-          GNUNET_break (0);
+          /* transfer present, but transfer _details_
+             missing (hence the SELECT returned an empty
+             set after intersection via USING part of the
+             query). Fine, we still need to talk to the
+             exchange! */
           break;
         case GNUNET_DB_STATUS_SUCCESS_ONE_RESULT:
           break;
@@ -1049,6 +1053,8 @@ TMH_private_post_transfers (const struct 
TMH_RequestHandler *rh,
                                              NULL);
         case GNUNET_DB_STATUS_SUCCESS_NO_RESULTS:
         case GNUNET_DB_STATUS_SUCCESS_ONE_RESULT:
+          GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+                      "post-transfer committed successfully\n");
           break;
         }
         download (ptc);
@@ -1056,6 +1062,8 @@ TMH_private_post_transfers (const struct 
TMH_RequestHandler *rh,
       }
     case GNUNET_DB_STATUS_SUCCESS_ONE_RESULT:
       /* Transfer exists */
+      GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+                  "Transfer exists in DB\n");
       if (! verified)
       {
         if (! ptc->downloaded)
@@ -1191,6 +1199,8 @@ TMH_private_post_transfers (const struct 
TMH_RequestHandler *rh,
                                              NULL);
         case GNUNET_DB_STATUS_SUCCESS_NO_RESULTS:
         case GNUNET_DB_STATUS_SUCCESS_ONE_RESULT:
+          GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+                      "post-transfer committed uselessly\n");
           break;
         }
 

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.