[gnunet] branch master updated: -coverity; do not use assertion for actual code -- bad style

[gnunet]

This is an automated email from the git hooks/post-receive script.

martin-schanzenbach pushed a commit to branch master
in repository gnunet.

The following commit(s) were added to refs/heads/master by this push:
     new ab49acfcc -coverity; do not use assertion for actual code -- bad style
ab49acfcc is described below

commit ab49acfccf8b3d5f5f48aaad990417b031db1067
Author: Martin Schanzenbach <mschanzenbach@posteo.de>
AuthorDate: Sat May 15 18:26:20 2021 +0200

    -coverity; do not use assertion for actual code -- bad style
---
 src/arm/arm_api.c | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/src/arm/arm_api.c b/src/arm/arm_api.c
index 2ec913a0a..0bffbc26d 100644
--- a/src/arm/arm_api.c
+++ b/src/arm/arm_api.c
@@ -433,12 +433,10 @@ handle_arm_list_result (void *cls,
     const char *name;
     const char *binary;
 
-    GNUNET_assert (NULL != (name = pool_get (pool_start,
-                                             pool_size,
-                                             name_index)));
-    GNUNET_assert (NULL != (binary = pool_get (pool_start,
-                                               pool_size,
-                                               binary_index)));
+    name = pool_get (pool_start, pool_size, name_index);
+    binary = pool_get (pool_start, pool_size, binary_index);
+    GNUNET_assert (NULL != name);
+    GNUNET_assert (NULL != binary);
     list[i] = (struct GNUNET_ARM_ServiceInfo) {
       .name = name,
       .binary = binary,
@@ -978,15 +976,16 @@ GNUNET_ARM_request_service_start (struct 
GNUNET_ARM_Handle *h,
   {
     GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING,
                          "pipe");
-  }
-  wsig = GNUNET_DISK_pipe_detach_end (sig,
+  } else {
+    wsig = GNUNET_DISK_pipe_detach_end (sig,
                                       GNUNET_DISK_PIPE_END_WRITE);
-  ret = start_arm_service (h,
-                           std_inheritance,
-                           wsig);
-  GNUNET_DISK_file_close (wsig);
-  if (GNUNET_ARM_RESULT_STARTING == ret)
-    reconnect_arm (h);
+    ret = start_arm_service (h,
+                             std_inheritance,
+                             wsig);
+    GNUNET_DISK_file_close (wsig);
+    if (GNUNET_ARM_RESULT_STARTING == ret)
+      reconnect_arm (h);
+  }
   op = GNUNET_new (struct GNUNET_ARM_Operation);
   op->h = h;
   op->result_cont = cont;

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.