gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[taler-merchant-backoffice] branch master updated (6f626b2 -> 3e3c9d3)


From: gnunet
Subject: [taler-merchant-backoffice] branch master updated (6f626b2 -> 3e3c9d3)
Date: Sat, 22 May 2021 12:48:09 +0200

This is an automated email from the git hooks/post-receive script.

ttn pushed a change to branch master
in repository merchant-backoffice.

    from 6f626b2  remove period at end of phrase
     new 868c90b  fix typo: s/and/an/
     new 66b1d38  grammar: s/This ... use/These ... used/
     new d9a5034  grammar: s/this/these/
     new 20f5fef  fix typo: s/places/placed/
     new 82a64e9  s/Thats/That's/
     new dd10946  s/others/other/
     new 824babd  s/is/are/
     new 7944e5a  s/reuse/reused/
     new cc120b1  s/target/targets/
     new 7ff0117  add auxiliary verb: ‘do’
     new 3e3c9d3  capitalize ‘english’

The 11 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 DESIGN.md | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/DESIGN.md b/DESIGN.md
index 620684b..b079ea4 100644
--- a/DESIGN.md
+++ b/DESIGN.md
@@ -49,7 +49,7 @@ When receiving an another error (400 < http status < 600), 
the login form should
 be shown with an error message using the hint from the backend.
 
 On other unexpected error (like network error), the login form should be shown
-with and error message.
+with an error message.
 
 ## CRUD operation (async)
 
@@ -84,7 +84,7 @@ const errors = {
 }
 ```
 
-This 3 elements are use to setup the FormProvider
+These 3 elements are used to setup the FormProvider
 
 ```
 <FormProvider errors={errors} object={state} valueHandler={setState}>
@@ -98,7 +98,7 @@ Inputs should handle UI rendering and use `useField(name)` to 
get:
   * value: the current value of the object
   * onChange: function to update the current field
 
-Also, every input must be ready to receive this properties
+Also, every input must be ready to receive these properties
 
   * name: property of the form object being manipulated
   * label: how the name of the property will be shown in the UI
@@ -115,7 +115,7 @@ under `tests/hooks`. Starts with the `use` word.
 
 # Contexts
 
-All the contexts should be places in the folder `src/context` as a function.
+All the contexts should be placed in the folder `src/context` as a function.
 Should expose provider as a component `<XxxContextProvider />` and consumer as 
a
 hook function `useXxxContext()` (where XXX is the name)
 
@@ -125,21 +125,21 @@ Type of components:
 
  * main entry point: src/index.tsx, mostly initialization
 
- * routing: in the `src` folder, deciding who is going to take the work. Thats
+ * routing: in the `src` folder, deciding who is going to take the work. That's
    when the page is loading but also create navigation handlers
 
  * pages: in the `paths` folder, setup page information (like querying the
    backend for the list of things), handlers for CRUD events, delegated routing
    to parent and UI to children.
 
-Some others guidelines:
+Some other guidelines:
 
- * Hooks over classes is preferred
+ * Hooks over classes are preferred
 
- * Components that are ready to be reuse on any place should be in
+ * Components that are ready to be reused on any place should be in
    `src/components` folder
 
- * Since one of the build target is a single bundle with all the pages, we are
+ * Since one of the build targets is a single bundle with all the pages, we are
    avoiding route based code splitting
    https://github.com/preactjs/preact-cli#route-based-code-splitting
 
@@ -148,7 +148,7 @@ Some others guidelines:
 
 Every components should have examples using storybook (xxx.stories.tsx). There
 is an automated test that check that every example can be rendered so we make
-sure that we not add a regression.
+sure that we do not add a regression.
 
 Every hook should have examples under `tests/hooks` with common usage trying to
 follow this structure:
@@ -173,7 +173,7 @@ https://es.reactjs.org/docs/accessibility.html
 
 # Internationalization
 
-Every non translated message should be written in english and wrapped into:
+Every non translated message should be written in English and wrapped into:
 
  * i18n function from useTranslator() hook
  * <Translate /> component

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]