[gnunet-scheme] 204/324: mq-impl/stream: Document implementation pitfall.

[gnunet]

This is an automated email from the git hooks/post-receive script.

maxime-devos pushed a commit to branch master
in repository gnunet-scheme.

commit 774d32465f8a81c2b7316e0957e80e0cccbe54df
Author: Maxime Devos <maximedevos@telenet.be>
AuthorDate: Sat Aug 28 12:10:38 2021 +0200

    mq-impl/stream: Document implementation pitfall.
    
    * gnu/gnunet/mq-impl/stream.scm
      (port->message-queue): Document it in the write fiber.
---
 gnu/gnunet/mq-impl/stream.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/gnunet/mq-impl/stream.scm b/gnu/gnunet/mq-impl/stream.scm
index 14c1931..a050f74 100644
--- a/gnu/gnunet/mq-impl/stream.scm
+++ b/gnu/gnunet/mq-impl/stream.scm
@@ -312,6 +312,14 @@ XXX: Likewise for connect/fibers?"
                   (perform-operation
                    (choice-operation
                     (prepare-await-trigger! rcvar)
+                     ;; Don't wait for the port to be writable here!
+                     ;;
+                     ;; Otherwise, if the port is writable, but the message
+                     ;; queue has nothing buffered for a while, the fiber
+                     ;; keeps spinning.
+                     ;;
+                     ;; XXX it would be nice if it could be detected when the
+                     ;; write end of the port is closed.
                     escape-when-closed-operation)))
                 (define (wait!/blocking)
                   (perform-operation wait-writable-operation))

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.