[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnunet-scheme] 246/324: mq,mq-impl: Remove TODOs about allocating memor
From: |
gnunet |
Subject: |
[gnunet-scheme] 246/324: mq,mq-impl: Remove TODOs about allocating memory. |
Date: |
Tue, 21 Sep 2021 13:24:46 +0200 |
This is an automated email from the git hooks/post-receive script.
maxime-devos pushed a commit to branch master
in repository gnunet-scheme.
commit b735e8c12641dee4936d395f8b90d68f3f25adb3
Author: Maxime Devos <maximedevos@telenet.be>
AuthorDate: Wed Sep 8 16:09:08 2021 +0200
mq,mq-impl: Remove TODOs about allocating memory.
These seemed like a good idea at the time, but eliminating
all OOM errors seems to be unrealistic now.
* gnu/gnunet/mq-impl/stream.scm
(handle-input!)[handle/message]: Remove TODO about allocating memory.
* gnu/gnunet/mq.scm
(inject-message!): Remove TODO about catching OOM and stack overflow
errors.
---
gnu/gnunet/mq-impl/stream.scm | 1 -
gnu/gnunet/mq.scm | 2 --
2 files changed, 3 deletions(-)
diff --git a/gnu/gnunet/mq-impl/stream.scm b/gnu/gnunet/mq-impl/stream.scm
index 15974a0..92715da 100644
--- a/gnu/gnunet/mq-impl/stream.scm
+++ b/gnu/gnunet/mq-impl/stream.scm
@@ -137,7 +137,6 @@ TODO closing message queues."
(! (handle/message bv offset length)
(inject-message!
mq
- ;; TODO: this allocates memory
(slice/read-only
(bv-slice/read-write bv offset length))))
(! (return/overly-small type size)
diff --git a/gnu/gnunet/mq.scm b/gnu/gnunet/mq.scm
index e1be5d4..73528b9 100644
--- a/gnu/gnunet/mq.scm
+++ b/gnu/gnunet/mq.scm
@@ -228,8 +228,6 @@ of message queues."
(inject-error! mq 'logic:no-handler type))
(? (not (verify-message? handler message))
(inject-error! mq 'logic:ill-formed type)))
- ;; TODO: maybe a good place to catch out-of-memory
- ;; and stack overflow errors ...
(handle-message! handler message)))
(define (inject-error! mq key . rest)
--
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.
- [gnunet-scheme] 209/324: doc: Resolve the TODO about broken pipes., (continued)
- [gnunet-scheme] 209/324: doc: Resolve the TODO about broken pipes., gnunet, 2021/09/21
- [gnunet-scheme] 213/324: nse/client: Use 'message-handler' macro., gnunet, 2021/09/21
- [gnunet-scheme] 222/324: mq-impl/stream: Handle closed ports more gracefully., gnunet, 2021/09/21
- [gnunet-scheme] 223/324: mq,doc: Update TODOs about message queues., gnunet, 2021/09/21
- [gnunet-scheme] 224/324: doc: Don't forget the message verifier., gnunet, 2021/09/21
- [gnunet-scheme] 225/324: mq: Inject errors when message verification has negative result., gnunet, 2021/09/21
- [gnunet-scheme] 234/324: doc: Remove resolved TODO., gnunet, 2021/09/21
- [gnunet-scheme] 240/324: mq-impl/stream: Handle ECONNRESET gracefully., gnunet, 2021/09/21
- [gnunet-scheme] 238/324: mq-impl/stream: Allow closing queues made with connect-fibers., gnunet, 2021/09/21
- [gnunet-scheme] 244/324: doc: Document the 'disconnected' callback., gnunet, 2021/09/21
- [gnunet-scheme] 246/324: mq,mq-impl: Remove TODOs about allocating memory.,
gnunet <=
- [gnunet-scheme] 245/324: mq-impl/stream: Eliminate 'return' argument of 'handle-input!'., gnunet, 2021/09/21
- [gnunet-scheme] 251/324: tests/utils: Move call-with-spawner from tests/mq-stream.scm., gnunet, 2021/09/21
- [gnunet-scheme] 221/324: mq-impl/stream: Delay knowing the port., gnunet, 2021/09/21
- [gnunet-scheme] 228/324: doc/fdl: Correct ‘quote’ typography., gnunet, 2021/09/21
- [gnunet-scheme] 231/324: doc: Document message verifiers., gnunet, 2021/09/21
- [gnunet-scheme] 236/324: mq-impl/stream: Close the port when stopping the fibers., gnunet, 2021/09/21
- [gnunet-scheme] 242/324: nse/client: Remove unused fields., gnunet, 2021/09/21
- [gnunet-scheme] 243/324: doc/scheme-gnunet.tm: Correct use of 'connected' and 'updated'., gnunet, 2021/09/21
- [gnunet-scheme] 237/324: mq-impl/stream: Allow closing the queue on request., gnunet, 2021/09/21
- [gnunet-scheme] 247/324: nse/client: Only call 'send-start!' after 'mq' has been defined., gnunet, 2021/09/21