gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnunet-scheme] 246/324: mq,mq-impl: Remove TODOs about allocating memor


From: gnunet
Subject: [gnunet-scheme] 246/324: mq,mq-impl: Remove TODOs about allocating memory.
Date: Tue, 21 Sep 2021 13:24:46 +0200

This is an automated email from the git hooks/post-receive script.

maxime-devos pushed a commit to branch master
in repository gnunet-scheme.

commit b735e8c12641dee4936d395f8b90d68f3f25adb3
Author: Maxime Devos <maximedevos@telenet.be>
AuthorDate: Wed Sep 8 16:09:08 2021 +0200

    mq,mq-impl: Remove TODOs about allocating memory.
    
    These seemed like a good idea at the time, but eliminating
    all OOM errors seems to be unrealistic now.
    
    * gnu/gnunet/mq-impl/stream.scm
      (handle-input!)[handle/message]: Remove TODO about allocating memory.
    * gnu/gnunet/mq.scm
      (inject-message!): Remove TODO about catching OOM and stack overflow
      errors.
---
 gnu/gnunet/mq-impl/stream.scm | 1 -
 gnu/gnunet/mq.scm             | 2 --
 2 files changed, 3 deletions(-)

diff --git a/gnu/gnunet/mq-impl/stream.scm b/gnu/gnunet/mq-impl/stream.scm
index 15974a0..92715da 100644
--- a/gnu/gnunet/mq-impl/stream.scm
+++ b/gnu/gnunet/mq-impl/stream.scm
@@ -137,7 +137,6 @@ TODO closing message queues."
             (! (handle/message bv offset length)
                (inject-message!
                 mq
-                ;; TODO: this allocates memory
                 (slice/read-only
                  (bv-slice/read-write bv offset length))))
             (! (return/overly-small type size)
diff --git a/gnu/gnunet/mq.scm b/gnu/gnunet/mq.scm
index e1be5d4..73528b9 100644
--- a/gnu/gnunet/mq.scm
+++ b/gnu/gnunet/mq.scm
@@ -228,8 +228,6 @@ of message queues."
                (inject-error! mq 'logic:no-handler type))
             (? (not (verify-message? handler message))
                (inject-error! mq 'logic:ill-formed type)))
-           ;; TODO: maybe a good place to catch out-of-memory
-           ;; and stack overflow errors ...
            (handle-message! handler message)))
 
     (define (inject-error! mq key . rest)

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]