[gnunet-scheme] 02/05: dht/client: By default don't linger.

[gnunet]

This is an automated email from the git hooks/post-receive script.

maxime-devos pushed a commit to branch master
in repository gnunet-scheme.

commit bdd31c383e6626df3852d9aafe5cb33ed51a6c7e
Author: Maxime Devos <maximedevos@telenet.be>
AuthorDate: Fri Feb 18 16:38:48 2022 +0000

    dht/client: By default don't linger.
    
    * doc/distributed-hash-table.scm (start-get!): Document new
      behaviour.  Remove resolved TODO.
    * gnu/gnunet/dht/client.scm (start-get!): Set 'linger?=#true' by
      default.  Document new behaviour.
---
 doc/distributed-hash-table.tm | 8 ++++----
 gnu/gnunet/dht/client.scm     | 9 ++++-----
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/doc/distributed-hash-table.tm b/doc/distributed-hash-table.tm
index b5b41f0..295a255 100644
--- a/doc/distributed-hash-table.tm
+++ b/doc/distributed-hash-table.tm
@@ -137,7 +137,7 @@
 
   <\explain>
     <scm|(start-get! <var|server> <var|query> <var|found>
-    <var|#:linger?>=#true)><index|start-get!>
+    <var|#:linger?>=#false)><index|start-get!>
   <|explain>
     Search for data matching <var|query> in the DHT. When a datum is found,
     call the unary procedure <var|found> on the search result. It is possible
@@ -156,9 +156,9 @@
     overwritten after the call to <var|found>. As such, it might be necessary
     to make a copy of the search result, using <scm|copy-search-result>.
 
-    When the boolean <var|linger?> is false, the search is automatically
-    cancelled when the search object becomes unreachable according to the GC.
-    <todo|actually implement this>
+    When the boolean <var|linger?> is false (this is the default), the search
+    is automatically cancelled when the search object becomes unreachable
+    according to the GC.
 
     <\warning>
       Guile currently (3.0.8) uses a conservative GC, so it cannot always
diff --git a/gnu/gnunet/dht/client.scm b/gnu/gnunet/dht/client.scm
index 9d37f0f..59f07d7 100644
--- a/gnu/gnunet/dht/client.scm
+++ b/gnu/gnunet/dht/client.scm
@@ -677,8 +677,7 @@ do anything if @var{server} has been permanently 
disconnected."
             (assert (block-type? type))
             (value->index type))))
 
-    ;; TODO(tests): Disable lingering by default, test linger?=#false
-    (define* (start-get! server query found #:key (linger? #true))
+    (define* (start-get! server query found #:key (linger? #false))
       "Search for data matching query in the DHT. When a datum is found, call
 the unary procedure @var{found} on the search result. It is possible to find
 multiple data matching a query. In that case, found is called multiple times.
@@ -695,9 +694,9 @@ buffers for the slices passed to @var{found}, which could 
be overwritten after
 the call to @var{found}. As such, it might be necessary to make a copy of the
 search result, using @lisp{copy-search-result}.
 
-When the boolean @var{linger?} is false, the search is automatically
-cancelled when the search object becomes unreachable according to the GC.
-TODO: implement this behaviour!"
+When the boolean @var{linger?} is false (this is the default), the search is
+automatically cancelled when the search object becomes unreachable according
+to the GC."
       ;; TODO: options, xquery ...
       (define id (fresh-id server))
       (define options 0) ; TODO: allow setting some options

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.