[gnunet] branch master updated: -fix coverity; remove unnecessary API

[gnunet]

This is an automated email from the git hooks/post-receive script.

martin-schanzenbach pushed a commit to branch master
in repository gnunet.

The following commit(s) were added to refs/heads/master by this push:
     new 434742461 -fix coverity; remove unnecessary API
434742461 is described below

commit 434742461540aa10e73fa4bb57750ad01eb7d9fe
Author: Martin Schanzenbach <schanzen@gnunet.org>
AuthorDate: Thu Sep 1 14:11:39 2022 +0200

    -fix coverity; remove unnecessary API
---
 src/identity/plugin_rest_identity.c |  9 +++---
 src/include/gnunet_crypto_lib.h     | 64 +++++--------------------------------
 src/util/crypto_ecc.c               | 44 -------------------------
 3 files changed, 12 insertions(+), 105 deletions(-)

diff --git a/src/identity/plugin_rest_identity.c 
b/src/identity/plugin_rest_identity.c
index f46de1091..9ff566b93 100644
--- a/src/identity/plugin_rest_identity.c
+++ b/src/identity/plugin_rest_identity.c
@@ -1227,7 +1227,7 @@ ego_sign_data_cb (void *cls, struct GNUNET_IDENTITY_Ego 
*ego)
 
   if ( GNUNET_OK != GNUNET_CRYPTO_eddsa_sign_raw (&(ego->pk.eddsa_key),
                                                   (void *) data,
-                                                  strlen (data),
+                                                  strlen ( (char*) data),
                                                   &sig))
   {
     handle->response_code = MHD_HTTP_INTERNAL_SERVER_ERROR;
@@ -1236,10 +1236,9 @@ ego_sign_data_cb (void *cls, struct GNUNET_IDENTITY_Ego 
*ego)
     return;
   }
 
-  sig_str = malloc (128);
-  GNUNET_CRYPTO_eddsa_signature_encode (
-    (const struct GNUNET_CRYPTO_EddsaSignature *) &sig,
-    &sig_str);
+  GNUNET_STRINGS_base64url_encode (&sig,
+                                   sizeof (struct 
GNUNET_CRYPTO_EddsaSignature),
+                                   &sig_str);
 
   GNUNET_asprintf (&result,
                    "{\"signature\": \"%s\"}",
diff --git a/src/include/gnunet_crypto_lib.h b/src/include/gnunet_crypto_lib.h
index b41eea8a3..7ff50dda1 100644
--- a/src/include/gnunet_crypto_lib.h
+++ b/src/include/gnunet_crypto_lib.h
@@ -1950,13 +1950,13 @@ GNUNET_CRYPTO_ecdsa_sign_ (
   struct GNUNET_CRYPTO_EcdsaSignature *sig);
 
 /**
- * @brief 
- * 
- * @param priv 
- * @param data 
- * @param len 
- * @param sig 
- * @return enum GNUNET_GenericReturnValue 
+ * @brief
+ *
+ * @param priv
+ * @param data
+ * @param len
+ * @param sig
+ * @return enum GNUNET_GenericReturnValue
  */
 enum GNUNET_GenericReturnValue
 GNUNET_CRYPTO_eddsa_sign_raw (
@@ -1965,54 +1965,6 @@ GNUNET_CRYPTO_eddsa_sign_raw (
   size_t size,
   struct GNUNET_CRYPTO_EddsaSignature *sig);
 
-/**
- * @brief 
- * 
- * @param sig 
- * @param sig_str 
- * @return enum GNUNET_GenericReturnValue 
- */
-size_t
-GNUNET_CRYPTO_eddsa_signature_encode(
-  const struct GNUNET_CRYPTO_EddsaSignature *sig,
-  char **sig_str);
-
-/**
- * @brief 
- * 
- * @param sig_str 
- * @param sig 
- * @return enum GNUNET_GenericReturnValue 
- */
-size_t
-GNUNET_CRYPTO_eddsa_signature_decode(
-  const char *sig_str,
-  struct GNUNET_CRYPTO_EddsaSignature *sig);
-
-/**
- * @brief 
- * 
- * @param sig 
- * @param sig_str 
- * @return enum GNUNET_GenericReturnValue 
- */
-size_t
-GNUNET_CRYPTO_ecdsa_signature_encode(
-  const struct GNUNET_CRYPTO_EcdsaSignature *sig,
-  char **sig_str);
-
-/**
- * @brief 
- * 
- * @param sig_str 
- * @param sig 
- * @return enum GNUNET_GenericReturnValue 
- */
-size_t
-GNUNET_CRYPTO_ecdsa_signature_decode(
-  const char *sig_str,
-  struct GNUNET_CRYPTO_EcdsaSignature *sig);
-
 /**
  * @ingroup crypto
  * @brief ECDSA sign a given block.
@@ -2491,7 +2443,7 @@ GNUNET_CRYPTO_paillier_decrypt (
 
 
 /**
- * Compute a ciphertext that represents the sum of the plaintext in @a c1 
+ * Compute a ciphertext that represents the sum of the plaintext in @a c1
  * and @a c2
  *
  * Note that this operation can only be done a finite number of times
diff --git a/src/util/crypto_ecc.c b/src/util/crypto_ecc.c
index 8eba2f635..c4f0e64bd 100644
--- a/src/util/crypto_ecc.c
+++ b/src/util/crypto_ecc.c
@@ -614,50 +614,6 @@ GNUNET_CRYPTO_eddsa_sign_raw (
   return (res == 0) ? GNUNET_OK : GNUNET_SYSERR;
 }
 
-size_t
-GNUNET_CRYPTO_eddsa_signature_encode (
-  const struct GNUNET_CRYPTO_EddsaSignature *sig,
-  char **sig_str)
-{
-  return GNUNET_STRINGS_base64url_encode (
-    (void*) sig,
-    64,
-    sig_str);
-}
-
-size_t
-GNUNET_CRYPTO_eddsa_signature_decode (
-  const char *sig_str,
-  struct GNUNET_CRYPTO_EddsaSignature *sig)
-{
-  return GNUNET_STRINGS_base64url_decode (
-    sig_str, 
-    strlen (sig_str),
-    (void **) &sig);
-}
-
-size_t
-GNUNET_CRYPTO_ecdsa_signature_encode (
-  const struct GNUNET_CRYPTO_EcdsaSignature *sig,
-  char **sig_str)
-{
-  return GNUNET_STRINGS_base64url_encode (
-    (void*) sig,
-    64,
-    sig_str);
-}
-
-size_t
-GNUNET_CRYPTO_ecdsa_signature_decode (
-  const char *sig_str,
-  struct GNUNET_CRYPTO_EcdsaSignature *sig)
-{
-  return GNUNET_STRINGS_base64url_decode (
-    sig_str, 
-    strlen (sig_str),
-    (void **) &sig);
-}
-
 
 enum GNUNET_GenericReturnValue
 GNUNET_CRYPTO_eddsa_sign_ (

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.