[gnunet] branch master updated: - coverity fixes

[gnunet]

This is an automated email from the git hooks/post-receive script.

martin-schanzenbach pushed a commit to branch master
in repository gnunet.

The following commit(s) were added to refs/heads/master by this push:
     new 6254d688a - coverity fixes
6254d688a is described below

commit 6254d688ac407ec60bea0e317a15978eac60b16f
Author: Martin Schanzenbach <schanzen@gnunet.org>
AuthorDate: Sat Oct 1 10:42:43 2022 +0900

    - coverity fixes
---
 src/namestore/gnunet-service-namestore.c | 8 ++++----
 src/rest/gnunet-rest-server.c            | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/namestore/gnunet-service-namestore.c 
b/src/namestore/gnunet-service-namestore.c
index 36f6d337c..b860d7a3c 100644
--- a/src/namestore/gnunet-service-namestore.c
+++ b/src/namestore/gnunet-service-namestore.c
@@ -806,7 +806,7 @@ send_lookup_response_with_filter (struct NamestoreClient 
*nc,
   rd_ser_len = GNUNET_GNSRECORD_records_get_size (res_count, res);
   if (rd_ser_len < 0)
   {
-    if (rd != res)
+    if (rd_nf != res)
       GNUNET_free (res);
     GNUNET_break (0);
     GNUNET_SERVICE_client_drop (nc->client);
@@ -814,7 +814,7 @@ send_lookup_response_with_filter (struct NamestoreClient 
*nc,
   }
   if (((size_t) rd_ser_len) >= UINT16_MAX - name_len - sizeof(*zir_msg))
   {
-    if (rd != res)
+    if (rd_nf != res)
       GNUNET_free (res);
     GNUNET_break (0);
     GNUNET_SERVICE_client_drop (nc->client);
@@ -1827,7 +1827,7 @@ handle_tx_control (void *cls, const struct 
TxControlMessage *tx_msg)
   struct TxControlResultMessage *txr_msg;
   struct GNUNET_MQ_Envelope *env;
   enum GNUNET_GenericReturnValue ret;
-  char *emsg;
+  char *emsg = NULL;
   char *err_tmp;
   size_t err_len;
 
@@ -1852,7 +1852,7 @@ handle_tx_control (void *cls, const struct 
TxControlMessage *tx_msg)
   }
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "TX status is %u\n", ret);
-  err_len = (GNUNET_YES == ret) ? 0 : strlen (emsg) + 1;
+  err_len = (NULL == emsg) ? 0 : strlen (emsg) + 1;
   env =
     GNUNET_MQ_msg_extra (txr_msg,
                          err_len,
diff --git a/src/rest/gnunet-rest-server.c b/src/rest/gnunet-rest-server.c
index 9984478ce..0aba52a11 100644
--- a/src/rest/gnunet-rest-server.c
+++ b/src/rest/gnunet-rest-server.c
@@ -1201,7 +1201,7 @@ run (void *cls,
       memset (basic_auth_secret_tmp, 0, 16);
       if (GNUNET_SYSERR == GNUNET_DISK_fn_read (basic_auth_file,
                                                 basic_auth_secret_tmp,
-                                                sizeof 
(basic_auth_secret_tmp)))
+                                                sizeof (basic_auth_secret_tmp) 
- 1))
       {
         GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                     "Unable to read basic auth secret file.\n");

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.