gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Minor NSObject.m exception message improvement


From: Nicola Pero
Subject: Minor NSObject.m exception message improvement
Date: Thu, 31 Jan 2002 15:23:27 +0000 (GMT)

What about this patch ?  Makes sense ?

Index: NSObject.m
===================================================================
RCS file: /cvsroot/gnustep/gnustep/core/base/Source/NSObject.m,v
retrieving revision 1.131
diff -u -r1.131 NSObject.m
--- NSObject.m  7 Jan 2002 15:34:20 -0000       1.131
+++ NSObject.m  31 Jan 2002 15:09:37 -0000
@@ -808,8 +808,10 @@
 - (void) doesNotRecognizeSelector: (SEL)aSelector
 {
   [NSException raise: NSInvalidArgumentException
-              format: @"%s does not recognize %s",
-              object_get_class_name(self), sel_get_name(aSelector)];
+              format: @"%s(%s) does not recognize %s",
+              object_get_class_name(self), 
+              GSObjCIsInstance(self) ? "instance" : "class",
+              sel_get_name(aSelector)];
 }
 
 - (retval_t) forward:(SEL)aSel :(arglist_t)argFrame
@@ -1221,15 +1223,19 @@
 {
   [NSException
     raise: NSGenericException
-    format: @"method %s not implemented in %s", sel_get_name(aSel), 
object_get_class_name(self)];
+    format: @"method %s not implemented in %s(%s)", sel_get_name(aSel), 
+    object_get_class_name(self),
+    GSObjCIsInstance(self) ? "instance" : "class"];
   return nil;
 }
 
 - (id) doesNotRecognize: (SEL)aSel
 {
   [NSException raise: NSGenericException
-              format: @"%s does not recognize %s",
-              object_get_class_name(self), sel_get_name(aSel)];
+              format: @"%s(%s) does not recognize %s",
+              object_get_class_name(self), 
+              GSObjCIsInstance(self) ? "instance" : "class",
+              sel_get_name(aSel)];
   return nil;
 }
 
@@ -2339,8 +2345,10 @@
 - (id) subclassResponsibility: (SEL)aSel
 {
   [NSException raise: NSGenericException
-    format: @"subclass %s should override %s", object_get_class_name(self),
-    sel_get_name(aSel)];
+    format: @"subclass %s(%s) should override %s", 
+              object_get_class_name(self),
+              GSObjCIsInstance(self) ? "instance" : "class",
+              sel_get_name(aSel)];
   return nil;
 }
 
@@ -2348,8 +2356,10 @@
 {
   [NSException
     raise: NSGenericException
-    format: @"%s should not implement %s", 
-    object_get_class_name(self), sel_get_name(aSel)];
+    format: @"%s(%s) should not implement %s", 
+    object_get_class_name(self), 
+    GSObjCIsInstance(self) ? "instance" : "class",
+    sel_get_name(aSel)];
   return nil;
 }
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]