Re: GDL2 - patches for OSX (1)

[Stéphane Corthésy]

[...]

> > EOControl/EODeprecated.h: new file declaring some deprecated methods/classes/symbols; methods/classes/symbols are still implemented but should no longer be used; they are no longer declared in their respective header files. 
>
> Hmm. ok we should have the file but as those methods are not really depricated for WO4.5, in fact we'll have to look in from where they came. I think we should create the file an insert those things that were depricated for WO4.5 (EOUndoManager, NSObject -flushClassKeyBindings, EOClassDescription delegate handling and the hint keys.  If you know what the depricated methods do and supply an implementation (I guess I'll create EODepricated.m file for the above anyway) then we could consider including them.


In fact, only declaration of methods/symbols has been moved to EODeprecated.h, as mentioned: implementation is still in the old location. No need to create a EODeprecated.m file.


> > EOControl/EOControl.h: added EODeprecated.h, EODefines.h, EOKeyValueCodingBase.h and EOArrayDataSource.h; removed EOUndoManager.h (deprecated)
> > EOControl/EOArrayDataSource.h/m: new files; some methods (<NSCoding> and qualifier bindings) are empty stubs
> >
> >
> >
> > ---
> > Index: EOControl.h
> > ===================================================================
> > RCS file: /cvsroot/gnustep/gnustep/dev-libs/gdl2/EOControl/EOControl.h,v
> > retrieving revision 1.4
> > diff -r1.4 EOControl.h
> > > #import <EOControl/EOKeyValueCodingBase.h> 
>
> Why do you need this?  I'm looking at obsoleting this file (and it's *.m counterpart).


I use only that part in .m:

#if FOUNDATION_HAS_KVC

// That's strange: there are no constants defined for these values,
// neither in GNUStep's nor in Apple's Foundation
NSString *EOUnknownKeyException = @"NSUnknownKeyException";
NSString *EOTargetObjectUserInfoKey = @"NSTargetObjectUserInfoKey";
NSString *EOUnknownUserInfoKey = @"NSUnknownUserInfoKey";

#endif

As on OSX we use Apple's implementation of KVC, we should refer to the same values for the exceptions in KVC.


> > ---
> > EOArrayDataSource.m
>
> [snip]
>
> > #import "EOArrayDataSource.h"
> > #import <EOControl/EOClassDescription.h>
> > #import <EOControl/EOEditingContext.h>
> > #import <EOControl/EODetailDataSource.h> 
>
> Please use #include <EOControl/EOFile.h> consistently.


Caramba! :-)


> > @implementation EOArrayDataSource
> >
> > - (id) initWithClassDescription:(EOClassDescription *)classDescription editingContext:(EOEditingContext *)context
> > {
> > // Either argument may be nil
> > if(self = [self init]){ 
>
> Please follow the http://www.gnu.org/prep/standards_toc.html and the existing conventions for GNUstep code.


OK, OK...


Stéphane



> > ---
> > EOArrayDataSource.h
> >
> > [snip]
>
> > #import <EOControl/EODataSource.h> 
>
> See above.
>
> I'll look into checking this in soon.
>
> Thanks,
> Dave
>
>
>
>
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/gnustep-dev