|
From: | Fred Kiefer |
Subject: | Change on NSControl |
Date: | Mon, 24 May 2004 16:47:25 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040114 |
Hi Quentin,could you please explain the change you made to the mousedown: method on NSControl? The change here looked rather strange to me, as the only super implementation for mouseDown: I could find was in NSResponder. So I searched around a bit more and found that extension of NSView in the GSToolbar.m file. This code structure isn't obvious, at least not to me. Perhaps you could write some comments on the toolbar validation to the mailing list and add them later on to the files, so this information wont get lost. Your change to the tracking rect handling may be obvious to you, but again it isn't to me.
The problem here is that if we don't document what is the intention, somebody else may break it later on, as they just don't know about it.
FredBTW: There are also a few compiler warnings from toolbar related classes. Could you please fix them.
[Prev in Thread] | Current Thread | [Next in Thread] |