Re: [patch] colors

[Nicolas Roard]

Le 29 mai 04, à 01:21, Quentin Mathé a écrit :

> Well, NSProgressIndicator needs to be improved… may be I will take 
> some times to do that.

That would be nice, yes. Support of the progress marks ?

> > It would be interesting to add a few new color names ... (eg, color 
> > names for the progress bar, for the background of "list" widgets, for 
> > the toolbar background...)
>
> I agree on that. I have already added an extra color list support in 
> the toolbar implementation which relies on a file called 
> "/Library/Colors/System extensions" and added also an NSColor category 
> to support extra method like +toolbarStandardBackgroundColor. I think 
> we can move this stuff out of the toolbar implementation in a special 
> file like NSColor+Extensions.m to standardize the things a bit without 
> shaking the openstep/cocoa specification.

Seems like a good solution.

> > Now -gui is fairly configurable with colors; the only remaining 
> > problems are the use of images for the checkbox, sliders and 
> > tabviews, which are then not in sync with the rest of the colormap.
>
> I think it will be perhaps too much cpu intensive (with difficult 
> coding process) to draw complex parts of the controls "by hand", then 
> it's probably better to stick to such images however it would be nice 
> to implement the possibility to draw everything "by hand" in the case 
> some themes very simplistic would be created.

hm, I partly disagree -- the only complex control here would be 
nstabview, and there is an existing patch for that one (hopefully it 
will be committed soon ;-)
Well, for the other controls like checkbox and sliders, I think the 
best way would be to simply modify the pixmaps so they use 
alphachannel; the drawing code will then just fill a rectangle of the 
right color (backgroundcolor) and composite the pixmap over it. That 
should do the work. I'll try to test that idea.

> In the case, we stick to such images, we must know that customizing 
> these hard coded images will be the job of the theme engine.

Actually, the theme engine could easily replace the pixmaps (that's 
what is done in camaelon); but imho it should be possible to change 
colors in normal gnustep gui and still have a consistent look :-)

thanks for the comments,

--
Nicolas Roard