Re: NSButtonCell value, contents and cell type implementation rewritten

[Quentin Mathé]

Le 31 août 04, à 03:51, Alexander Malmberg a écrit :

> Quentin Mathé wrote:
>
> > hmm, Alexander, is this ok to commit ?
>
> No. :)

You are joking, I'm sure :-).

> The cell type-related changes seem a bit odd. Could you explain why 
> this is the right thing to do?

Well it is explained in detail in the thread "[PATCH] Proposal to fix 
NSButtonCell issue with -setFont: -setTitle:" which is split between 
gnustep-dev and bug-gnustep…

> > --- 269,388 ----
> >   - (void) setTitle: (NSString*)aString
> ....
> > !   ASSIGN(_contents, aString);
>
> This should be ASSIGNCOPY, and likewise in the other methods for 
> setting the title/alternate title.

ok, I will correct this.

> For the new implementations of set*Value: in NSButtonCell to work 
> properly, you'll need to remove or rework the implementation of these 
> methods in NSButton.

ok, I will do it. But I would prefer to have this set of patches 
committed first, but I'm not sure it is possible…

> There seem to be some issues with redisplaying an NSButton after 
> calling these methods. Exactly where the redisplay is done is the 
> subject of future cleanups, but it does need to be done somewhere (ie. 
> calling [NSButton -set*Value:] must somehow result in a 
> -setNeedsDisplay: on the button if the state changes).

Well, I will need some more precise input or opinion from you here. 
Fred also probably ?

> Also, note that this changes the current behavior of NSButton in some 
> important ways. It's no longer possible to set the title using 
> -setStringValue:. This is correct, but it will break apps (Matt Rice 
> and I have cleaned up some of it, but there are still apps known to 
> break). Thus, I'm not sure whether it's appropriate to commit a change 
> like this close to a release. It's a matter or release-policy, though. 
> I'll send a more general mail to the list soon about this; this 
> shouldn't be committed until that has been resolved.

Well, I agree, it can wait the next release.

Quentin.

--
Quentin Mathé
address@hidden