Re: [Gnustep-cvs] Added editing methods.

[Alexander Malmberg]

Fred Kiefer wrote:
> --- gnustep/gnustep/core/gui/Source/NSControl.m 2004/05/28 23:49:15     1.63
> +++ gnustep/gnustep/core/gui/Source/NSControl.m 2004/09/24 16:35:41     1.64
[snip]
>  - (void) validateEditing
>  {
> -}                      
> +  NSText *t;
> +
> +  t = [self currentEditor];
> +  if (t == nil)
> +    {
> +      return;
[...]

This is wrong. You're completely ignoring the formatter. While this 
isn't the first bit of cell-related code that doesn't handle formatters 
correctly, I don't think it's a good idea to add _more_ such stopgap 
code unless there's a very good reason. Thus, why? As far as I can see, 
the code isn't used in -gui. How did you test it?

- Alexander Malmberg