Re: -gui warning cleanups

[Quentin Mathé]

Le 20 janv. 05, à 16:00, Alexander Malmberg a écrit :

> Newer versions of gcc are getting ever pickier, and combined with some 
> sloppy code that's piled up over time, the warning situation in 
> GNUstep has been gotten pretty bad lately. Thus, I've made a pass over 
> -gui and -back fixed warnings and other minor issues.
>
> I've attached the patch for  -gui. At lot of it is fairly obvious 
> stuff, but there are also some parts I'm less happy about (e.g. adding 
> tons of initializations to get rid of "might be used uninitialized" 
> warnings: I've checked all these cases, though, and they're ok in the 
> sense that nothing will be used uninitialized on valid input).
>
> I still think this is worth committing; if there are issues with the 
> code, I think it's better to track it by filing bugs or adding TODO 
> comments than to keep a warning around to remind you. However, I'll 
> wait a while before committing to see if anyone objects to any 
> particular cleanup.
>
> (There's also a matching patch for -back, but it doesn't really 
> contain anything interesting, so I'll just commit it when I commit 
> this.)

Well I have just taken a look to what you committed… Impressive commit 
indeed. :-)
-gui compilation looks really nice now.


> ChangeLog:
> 2005-01-19 15:11  Alexander Malmberg  <address@hidden>
>
>         Various whitespace cleanups, comment type fixes, and changes
>         to avoid warnings from recent versions of gcc.
>
>         * Headers/Additions/GNUstepGUI/GSToolbar.h (-_toolbars): 
> Declare.
>         * Source/NSWindow+Toolbar.m: Remove conflicting declaration of
>         [NSToolbar -_toolbars].

Just a comment for this correction… may be it would have been better to 
avoid the private method declaration in GSToolbar header and to put it 
in the top of NSWindow+Toolbar.m and GSToolbar.m with the code below :

@interface GSToolbar (GNUstepPrivate)
- (NSArray *) _toolbars;
@end

If I'm not too tired, I would say it shouldn't produce a warning…
What do you think ? I admit it is not very important however.

Quentin.

--
Quentin Mathé
address@hidden