Re: [Gnustep-cvs] gnustep/core/base ChangeLog Headers/Additions/G...

[Alex Perez]

Fred Kiefer wrote:
> Hi Richard,
>
> Richard Frith-Macdonald wrote:
>
> > CVSROOT:    /cvsroot/gnustep
> > Module name:    gnustep
> > Branch:    
> > Changes by:    Richard Frith-Macdonald <address@hidden>    
> > 05/02/23 16:05:09
> >
> > Modified files:
> >     core/base      : ChangeLog 
> >     core/base/Headers/Additions/GNUstepBase: GSFileHandle.h 
> >     core/base/Headers/Foundation: NSPort.h NSRunLoop.h 
> >     core/base/Source: GNUmakefile GSFileHandle.m GSLocale.m NSPipe.m 
> >                       NSRunLoop.m NSSocketPort.m NSThread.m NSUser.m 
> >     core/base/Source/Additions: GSXML.m     core/base/Testing: 
> > nsconnection.m nsfilehandle.m Added files:
> >     core/base/Source/unix: GNUmakefile GSRunLoopCtxt.m 
> >                            GSRunLoopWatcher.m Makefile.preamble 
> >     core/base/Source/win32: GNUmakefile GSRunLoopCtxt.m 
> >                             GSRunLoopWatcher.m Makefile.preamble 
> >                             NSRunLoopWin32.m
> > Log message:
> >     Apply modified patch to support windows native event handling
>
> Looks like you did miss out on a few header files when applying this 
> patch. When compiling base I get the following files listed as missing: 
> GNUstepBase/GSRunLoopCtxt.h
> GNUstepBase/GSRunLoopWatcher.h

Two for Two. This is a touchy subject, but it just keeps happening over 
and over and over again. Richard, would it be possible for you to 
actually /test/ the code you commit to CVS? (not the code you write on 
your machine, the actual code which actually gets comitted to CVS, the 
code other people must use)? The entire GNUstep community will benefit 
from higher QC, Lets learn from our mistakes, instead of repeating them 
bi-weekly.

Respectfully,
Alex Perez