Re: characterset support changes

[Benhur Stein]

On Tue, 8 Mar 2005 18:51:43 +0000, Richard Frith-Macdonald
<address@hidden> wrote:
> I have implemented the latest MacOS-X NSCharacterSet API ... [...] (and of 
> course report any bugs).

Hi. I took a look at the diffs out of curiosity and found this
definition in NSCharacterSet.m:

#define ISSET(a,i)      (((((a) & (1<<(i)))) > 0) ? YES : NO)

If a is signed, this macro will not work for the sign bit (the
resulting number will be < 0 when that bit is set). If a is unsigned,
it doesn't matter, but I would suggest to change it to "!= 0" anyway.

Benhur