gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Rewrite of NSView display methods


From: Fred Kiefer
Subject: Rewrite of NSView display methods
Date: Sat, 21 May 2005 19:15:35 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050414

While studying the EPS creation problem (#13140), I had a look at the different display methods on NSView. There is a lot of code duplication going on there and I would like to merge most of them together. For example have all the IfNeeded methods just check the flag and call their corresponding none checking method and similar rework. This would result in each simple display method using about three more method invokations then before. This may result in a tiny slow down (which I doubt anybody would notice), but also in cleaner, cosnsitent and easier to maintain code. Are there any objections to this change?

Merging the code raises the question, which of the two main implementations (displayRectIgnoringOpacity:, or displayIfNeededInRectIgnoringOpacity:) has the correct code? I think the later one.
And why is there extra handling in displayIfNeededIgnoringOpacity?

Cheers
Fred




reply via email to

[Prev in Thread] Current Thread [Next in Thread]