gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnustep-cvs] gnustep/core/base ChangeLog Headers/Foundation/...


From: Benhur Stein
Subject: Re: [Gnustep-cvs] gnustep/core/base ChangeLog Headers/Foundation/...
Date: Tue, 30 Aug 2005 14:39:23 -0300

On 8/30/05, Adam Fedor <address@hidden> wrote:
> [...] 
> Log message:
>         New implementation of NSSortDescriptor.
> 

In NSSortDescriptor.m, there is this method:

- (NSArray *) sortedArrayUsingDescriptors: (NSArray *) sortDescriptors
{
  NSMutableArray * sortedArray = [NSMutableArray arrayWithArray: self];

  [sortedArray sortUsingDescriptors: sortDescriptors];

  return [[sortedArray copy] autorelease];
}

Wouldn't it be better if the last line was (to spare a copy):
  return [sortedArray makeImmutableCopyOnFail:NO];

Benhur




reply via email to

[Prev in Thread] Current Thread [Next in Thread]