Re: [Gnustep-cvs] r24671 - /libs/gui/trunk/Source/NSAlert.m

[Sergii Stoian]

Hi, Matt.

Thank you. I'll update  Changelog along with  new fix.

Escape key sequence force alert panel to return 
as if other button clicked. I guess it is not the best way
to achieve what alert panel is bringing for. Anyway we can disscuss 
panel's behaviour. This is also the matter of user safety.

On 2/21/07, Matt Rice <address@hidden> wrote:

Also you forgot a ChangeLog entry,

I also believe this change to be dubious in that because key
equivalents
for return and escape exist, doesn't mean that someone wouldn't use
tab/space which they may be used to for other panels which do not have
return/escape key equivalents.

On 2007-02-21 01:31:04 -0800 Fred Kiefer <address@hidden> wrote:

> I am not sure, but wouldn't it be better to just switch of the display
> of the first responder frame by calling setShowsFirstResponder: on the
> cell with NO as the argument?
>
> On a not so related issue, you had to set the highlight behaviour for
> these buttons explicitly. What about setting the type of all these
> buttons to be NSMomentaryPushInButton in _makeButtonWithRect:. This
> looks more consistent to me. The default button would still be
> different
> though.
>
> Sergii Stoian schrieb:
>> Author: stoyan
>> Date: Wed Feb 21 01:46:01 2007
>> New Revision: 24671
>>
>> URL: http://svn.gna.org/viewcvs/gnustep?rev=24671&view=rev
>> Log:
>> * Source/NSAlert.m: (-_initWithoutGModel):
>> Make buttons refuse first responder to avoid drawing
>> dashed frame.
>>
>> Modified:
>>      libs/gui/trunk/Source/NSAlert.m
>>

-- 
Sergii Stoian, ProjectCenter maintainer