Re: Call for volunteers: Backporting mySTEP changes

[Xavier Glattard]

Selon Fred Kiefer <address@hidden>:

> Xavier Glattard wrote:
> > Fred Kiefer <fredkiefer <at> gmx.de> writes:
> > (...)
> >> 3. Changes to GNUstep
> >>
> >> mySTEP has a few correction and additions to methods that are already
> >> implemented in GNUstep. We should try to extract as much of these as
> >> possible. On the other hand have we fixed a lot of bugs in GNUstep since
> >> the fork. We don't want to loose these fixes. Quite often there are also
> >> two independent implementations of methods in GNUstep and mySTEP, so no
> >> benefit may be gained by merging them.
> >>
> >> This surely is the hardest case and should be done very carefully.
> > (...)
> >
> > I guess NSApplication and NSRunLoop stuff are in this category.
> > I had a quick look in myStep with a diff tool (on NSApplication and
> > NSRunLoop)and it seems all has been rewritten... Is there anything to
> > extract ? Or should it be better not to change anything ?
> > I mean : is there any 'political' point of view about this part of
> > GNUstep ?
> >
>
> I have limited my mail to the AppKit changes of mySTEP, let Richard
> comment on the ones to Foundation. In AppKit we have the nice situation
> that most code is not OS specific, this means some of the limitations of
> mySTEP don't apply here. Still we need to make sure we don't break any
> platform.

Ok. I won't bother you any more with RunLoop...
Well... for some time ;o)

> A diff will never work to find the changes in mySTEP as Nikolaus uses a
> completely different formatting style and methods have been moved around
> a lot in both branches since the fork. It is really down to doing a one
> method at a time comparison.

There are some differences in NSApplication. As this class is central i guess
many other classes use it and then it should be treated first.
A quick look in NSApplication.h shows me some additions :
- an event queue (i know : i promised ;o)
- global enum : NSApplicationDelegateReply, NSApplicationPrintReply
- some new methods (MacOS)

> > I'm a volunteer :-)
>
> Great, now there are two of us :-)
> Best you start out with the new classes I listed. They will need to get
> added to the GNUmakefile and the NSAppKit.h file and, what is more
> important, fill with code.

Ok. I will work on the first one : NSAnimation. Then the next one and so on
until i couldn't.

Is there a good example of gnustep coding standard conformity around ?

Xavier