Re: NSAnimation...

[Fred Kiefer]

For me it looks even worse:

 Compiling file NSAnimation.m ...
In file included from
/usr/GNUstep/System/Library/Headers/GNUstepBase/GSIArray.h:138,
                 from NSAnimation.m:53:
/usr/GNUstep/System/Library/Headers/GNUstepBase/GSUnion.h:112: error:
conflicting types for ‘NSAnimationProgress’
../Headers/AppKit/NSAnimation.h:164: error: previous declaration of
‘NSAnimationProgress’ was here
NSAnimation.m: In function ‘nsanimation_progressMarkSorter’:
NSAnimation.m:89: error: invalid operands to binary -
NSAnimation.m: In function ‘-[NSAnimation addProgressMark:]’:
NSAnimation.m:103: warning: conflicting types for
‘-(void)addProgressMark:(NSAnimationProgress)progress’
../Headers/AppKit/NSAnimation.h:209: warning: previous declaration of
‘-(void)addProgressMark:(NSAnimationProgress)progress’
NSAnimation.m:104: error: invalid operands to binary <
NSAnimation.m:104: error: incompatible types in assignment
NSAnimation.m:105: error: invalid operands to binary >
NSAnimation.m:105: error: incompatible types in assignment
NSAnimation.m:111: error: invalid operands to binary >=
NSAnimation.m:118: error: invalid operands to binary <
NSAnimation.m: In function ‘-[NSAnimation currentProgress]’:
NSAnimation.m:155: warning: conflicting types for
‘-(NSAnimationProgress)currentProgress’
../Headers/AppKit/NSAnimation.h:224: warning: previous declaration of
‘-(NSAnimationProgress)currentProgress’
NSAnimation.m:156: error: incompatible types in return
NSAnimation.m:157: warning: control reaches end of non-void function
NSAnimation.m: In function ‘-[NSAnimation
initWithDuration:animationCurve:]’:
NSAnimation.m:235: warning: assignment from incompatible pointer type
NSAnimation.m:237: warning: assignment from incompatible pointer type
NSAnimation.m: In function ‘-[NSAnimation progressMarks]’:
NSAnimation.m:301: error: incompatible type for argument 1 of
‘numberWithFloat:’
NSAnimation.m: In function ‘-[NSAnimation removeProgressMark:]’:
NSAnimation.m:311: warning: conflicting types for
‘-(void)removeProgressMark:(NSAnimationProgress)progress’
../Headers/AppKit/NSAnimation.h:249: warning: previous declaration of
‘-(void)removeProgressMark:(NSAnimationProgress)progress’
NSAnimation.m:312: warning: implicit declaration of function
‘GSIArraySearch’
NSAnimation.m:314: error: invalid operands to binary ==
NSAnimation.m: In function ‘-[NSAnimation setCurrentProgress:]’:
NSAnimation.m:394: warning: conflicting types for
‘-(void)setCurrentProgress:(NSAnimationProgress)progress’
../Headers/AppKit/NSAnimation.h:261: warning: previous declaration of
‘-(void)setCurrentProgress:(NSAnimationProgress)progress’
NSAnimation.m:398: error: invalid operands to binary <
NSAnimation.m:398: error: incompatible types in assignment
NSAnimation.m:399: error: invalid operands to binary >
NSAnimation.m:399: error: incompatible types in assignment
NSAnimation.m:409: error: invalid operands to binary ==
NSAnimation.m:416: error: invalid operands to binary <
NSAnimation.m:420: error: invalid operands to binary <
NSAnimation.m:432: error: incompatible types in assignment
NSAnimation.m:434: error: invalid operands to binary >=
NSAnimation.m: In function ‘-[NSAnimation startAnimation]’:
NSAnimation.m:499: warning: assignment from incompatible pointer type
NSAnimation.m:504: warning: assignment from incompatible pointer type
NSAnimation.m:531: warning: assignment from incompatible pointer type
NSAnimation.m:533: warning: assignment from incompatible pointer type
NSAnimation.m: In function ‘-[NSAnimation
startWhenAnimation:reachesProgress:]’:
NSAnimation.m:561: warning: conflicting types for
‘-(void)startWhenAnimation:(NSAnimation *)animation
reachesProgress:(NSAnimationProgress)start’
../Headers/AppKit/NSAnimation.h:280: warning: previous declaration of
‘-(void)startWhenAnimation:(NSAnimation *)animation
reachesProgress:(NSAnimationProgress)start’
NSAnimation.m:563: error: incompatible types in assignment
NSAnimation.m: In function ‘-[NSAnimation
stopWhenAnimation:reachesProgress:]’:
NSAnimation.m:582: warning: conflicting types for
‘-(void)stopWhenAnimation:(NSAnimation *)animation
reachesProgress:(NSAnimationProgress)stop’
../Headers/AppKit/NSAnimation.h:287: warning: previous declaration of
‘-(void)stopWhenAnimation:(NSAnimation *)animation
reachesProgress:(NSAnimationProgress)stop’
NSAnimation.m:584: error: incompatible types in assignment
NSAnimation.m: In function ‘-[NSAnimation animatorStep:]’:
NSAnimation.m:650: error: invalid initializer
NSAnimation.m:659: error: invalid operands to binary >
NSAnimation.m:665: error: incompatible type for argument 1 of
‘setCurrentProgress:’
NSAnimation.m: In function ‘-[NSAnimation(Private)
_gs:didReachProgressMark:]’:
NSAnimation.m:705: error: incompatible type for argument 4 of
‘self->_delegate_animationDidReachProgressMark’
NSAnimation.m:712: error: incompatible type for argument 2 of
‘animation:didReachProgressMark:’
NSAnimation.m:721: error: incompatible type for argument 1 of
‘numberWithFloat:’
NSAnimation.m:729: error: invalid operands to binary ==
NSAnimation.m: In function ‘-[NSAnimation(Private) _gs:curveShift]’:
NSAnimation.m:739: error: incompatible types in return
NSAnimation.m:739: warning: control reaches end of non-void function
NSAnimation.m: In function ‘-[NSViewAnimation setCurrentProgress:]’:
NSAnimation.m:1009: error: incompatible type for argument 1 of
‘setCurrentProgress:’
NSAnimation.m:1013: warning: multiple methods named
‘-setCurrentProgress:’ found
../Headers/AppKit/NSAnimation.h:261: warning: using
‘-(void)setCurrentProgress:(NSAnimationProgress)progress’
NSAnimation.m:394: warning: also found
‘-(void)setCurrentProgress:(NSAnimationProgress)progress’
make[2]: *** [obj/NSAnimation.o] Fehler 1

I currently don't have the time to look into this. Form a quick look it
is rather a problem in GSIArray than in NSAnimation. But Xavier, when
you fix it, could you please also move all the inline functions from the
header to the implementation file? We don't want to clutter up the
environment for all the users of this header file.

Could you please also move over to GNUstep indentation and white space
rules? It is not too hard you just need to get used to it.

Cheers,
Fred


Gregory John Casamento wrote:
> Xavier,
> 
> I am seeing the following error when compiling:
> 
> Making all for tool set_show_service...
>  Compiling file set_show_service.m ...
>  Linking tool set_show_service ...
> ../Source/./obj/libgnustep-gui.so: undefined reference to 
> `nsanimation_progressMarkSorter'
> collect2: ld returned 1 exit status
> make[2]: *** [obj/set_show_service] Error 1
> 
> I have tried to do a clean compilation twice now, with no luck. 
> 
> Thanks, GJC
> --
> Gregory Casamento
> 
> ----- Original Message ----
> From: Xavier Glattard <address@hidden>
> To: address@hidden
> Sent: Thursday, April 5, 2007 12:36:50 PM
> Subject: NSAnimation...
> 
> 
> Hello all :-)
> 
> I'm still working on the NSAnimation class, but i can't understand
> some parts of the specs... I need your opinion.
> 
> How should the array returned by [-runLoopModesForAnimating] be used ?
> 1) schedule one timer for each mode in the array ?
>    (so the animation runs whatever the mode will be)
> 2) start the animation only if [-currentMode] is in the array ?
> 3) something else ?
> 
> What should happen if [-runLoopModesForAnimating] is empty or contains
> only unknown modes ?
> 1) do nothing and return ?
> 2) immediatly call [GSAnimator -_animationEnd] and/or 
>    [NSAnimation -animatorDidStop] ?
> 3) wait 'duration' then stop ?
> 4) something else ?
> 
> At end a NSRunLoop question :
> What is the actual difference between
>   [-runMode:beforeDate:]
> and
>   [-acceptInputForMode:beforeDate:]
> Which one should i use with an NSAnimation-specific runLoop ?
> (blocking and threaded mode)
> 
> Many thnks ! 
> 
> Xavier
> 
> 
> 
> 
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnustep-dev
> 
> 
> 
> 
> 
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnustep-dev
>