gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Typo in gdomap.h ?


From: Philippe Roussel
Subject: Typo in gdomap.h ?
Date: Fri, 30 Nov 2007 17:35:45 +0100
User-agent: Mutt/1.5.11

Hi all

It seems this patch is needed for gdomap

Index: Tools/gdomap.h
===================================================================
--- Tools/gdomap.h      (revision 25630)
+++ Tools/gdomap.h      (copie de travail)
@@ -183,7 +183,7 @@
  */
 #define        GDO_NET_MASK    0x70    /* Network protocol of port.            
*/
 #define        GDO_NET_TCP     0x10
-#define        GDO_NET_UDP     0x10
+#define        GDO_NET_UDP     0x20
 #define        GDO_SVC_MASK    0x0f    /* High level protocol of port.         
*/
 #define        GDO_SVC_GDO     0x01
 #define        GDO_SVC_FOREIGN 0x02
 
Otherwise, I don't see how the following snippet from gdomap.c could
create an udp socket.

if ((ptype & GDO_NET_MASK) == GDO_NET_TCP)
{
        sock = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
}
else if ((ptype & GDO_NET_MASK) == GDO_NET_UDP)
{
        sock = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP);
}
                                        
If this is the intended behavior, could someone explain it to me ?

Thanks,
Philippe
-- 
When Dilbert has a better working environment than you its time to leave





reply via email to

[Prev in Thread] Current Thread [Next in Thread]