Re: [Gnustep-cvs] r26307 - /libs/gui/trunk/Source/NSApplication.m

[Fred Kiefer]

Fabien Vallon wrote:
> On Wed, 26 Mar 2008, Fred Kiefer wrote:
>> Riccardo Mottola wrote:
>>> Author: rmottola
>>> Date: Sun Mar 16 02:02:52 2008
>>> New Revision: 26307
>>>
>>> URL: http://svn.gna.org/viewcvs/gnustep?rev=26307&view=rev
>>> Log:
>>> changed terminate type to BOOL since it is one and the value froma delegate 
>>> got wrongly cast
>>>
>>> Modified:
>>>     libs/gui/trunk/Source/NSApplication.m
>>>
>> No it is not. The return value of applicationShouldTerminate: is of type
>>  NSApplicationTerminateReply and has been this since some time. It used
>> to be a BOOL in OpenStep. Could you please undo your change that
>> prevents the value of NSTerminateLater from being passed on and we may
>> check together what did go wrong in your original delegate.
> 
> I reported this bug on #gnustep.
> 
> You can try this simple example  here : 
> http://www.sonappart.net/gnustep/appdelegatebug.tar.gz
> 
> You can not quit the application.
> 

Strange, this application works for me even with the old GNUstep code.
Which environment are you on?
To be honest I don't see, how this could have failed even on a 64 bit
system, but then you never know.
Does it work with Richard latest change? That code looks as save as
possible to me.

Fred