Re: NSSound Commit

[Gregory Casamento]

Actually,

I put the Sounds into that folder with the intent of it being similar
to Images.   The bundles were put there by stefan.   I believe we
should move the bundles back to tools and leave the sound data in
Sounds.  I didn't want to suddenly move then on hum in case more
changes were pending.

Gc

On Sunday, August 23, 2009, Fred Kiefer <address@hidden> wrote:
> Thank you, but the compiler still fails when trying to compile the
> bundle in Sounds. Most like we need to check the value of BUILD_SOUNDS
> in the GNUmakefile there.
>
> Can anybody explain to me, why the sound bundle no longer is in Tools,
> but in Sounds now? I don't seem to understand the benefit of this.
>
> Fred
>
> Gregory Casamento schrieb:
>> I made the changes to fix this.  Update again.
>>
>> GC
>>
>> On Sun, Aug 23, 2009 at 3:45 AM, Fred Kiefer<address@hidden> wrote:
>>> Stef Bidi schrieb:
>>>> I just committed the new NSSound implementation.  Keep in mind it's very
>>>> rough at this point.  A few things, off the top of my head:
>>>>
>>>> * Need to check for libsndfile and libao, and only build SndfileSource and
>>>> AudioOutputSink if they exist;
>>>> * There's a hack in Sounds/GNUmakefile or else I could not get this thing 
>>>> to
>>>> build;
>>>> * Incorporate David C.'s suggestions.
>>>>
>>>> This thing needs lots of testing.  I'll post my test app tomorrow (I'm
>>>> pretty tired now) so you all can try it, too.
>>> I tried to compile GNUstep gui after your commit and it fails. Of course
>>> I don't have libsndfile-devel and libao-devel installed, but this will
>>> be the case for others as well. There should at least be a configure
>>> flag to disable the compilation of this code. Somebody has to do this
>>> today otherwise we get loads of bug reports about GNUstep no longer
>>> compiling. Also after any change to http://configure.ac you need to 
>>> regenerate
>>> configure and commit that as well.
>>>
>>> Sorry, I am thinking about reveting your commit now. The basic promise
>>> of trunk is that it compiles and more or less works all the time.
>>> Wouldn't it be better to have the sound code on the branch until it is
>>> mature enough at least not to break compilation?
>
>

-- 
Gregory Casamento
Open Logic Corporation, Principal Consultant
## GNUstep Chief Maintainer
yahoo/skype: greg_casamento, aol: gjcasa
(240)274-9630 (Cell), (301)362-9640 (Home)