Re: [Gnustep-cvs] r28522 - in /libs/gui/trunk: ChangeLog Headers/Additions/GNUstepGUI/GSTheme.h Source/GSThemeDrawing.m Source/NSButtonCell.m

[Richard Frith-Macdonald]

On 23 Aug 2009, at 21:08, Gregory John Casamento wrote:

> Richard,
>
> These are changes I'm making for the Windows native theme I'm  
> working on.
>
> In the native theme I'm using the UXTHEME library on Windows to  
> render the button images, so I needed a finer grained method to deal  
> just with that.
>
> The design is currently in flux, so it might change a lot over the  
> course of the next few days.
>
> I will try not to add any unnecessary complexity.

OK, not really convinced that using the existing method would not be  
better, but I'm not the one writing the software, so I'm not going to  
argue.

Should I add a method to allow themes to override how images draw  
themselves generally anyway?  It feels like a useful feature to have.

Are you going to commit the (trivial) change to thematic to support  
overriding of the new method?  I see you have added new controls to  
the main panel in Thematic.app, but haven't implemented support for  
them yet.  If you aren't planning to add support for them, perhaps we  
should either remove them again so that people don't think they should  
work, or modify the code to display a message making it clear they are  
not yet supported?