[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Working NSSearchFieldCell archiving support

From: Quentin Mathé
Subject: Re: [PATCH] Working NSSearchFieldCell archiving support
Date: Mon, 7 Sep 2009 17:14:19 +0200

Le 7 sept. 2009 à 16:10, Fred Kiefer a écrit :

I committed a slightly different patch, to keep the size of the class
the same. Please check that I didn't break anything.

I just tested it. Both keyed and non-keyed archiving works fine. Thanks :-)

The only thing I'm not convinced is the change of the NSMenuItem type to id <NSMenuItem> if it's only a purpose is to eliminate the NSValidatedUserInterfaceItem related warning. The change is fine if GNUstep is going to continue to support NSMenuItem protocol though.

I'd like to suggest to make NSMenuItem protocol conforms to NSValidatedUserInterfaceItemProtocol as Apple did:

The change is really simple:
@protocol NSMenuItem <NSValidatedUserInterfaceItem, NSCopying, NSCoding, NSObject>

This would eliminate warnings in many GNUstep applications (e.g. Gorm) which use the NSMenuItem class type.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]