[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: NSColor extensions (Was: New features)

From: Richard Frith-Macdonald
Subject: Re: NSColor extensions (Was: New features)
Date: Mon, 2 Nov 2009 06:19:11 +0000

On 1 Nov 2009, at 22:15, Fred Kiefer wrote:

Fred Kiefer schrieb:
Specifically for the menu item colour I am thinking about making the
system extension colour list, that is already used in GSToolbarView an official GNUstep mechanism, move the code over to NSColor and to add all the other colour definitions we have scattered in GNUstep gui (I think
NSTableView uses some, hints to other places are welcome). That way a
theme would just need to override one extra colour list.

I am having second thoughts on my own proposal.
The interplay between NSColor and GSTheme is already complex enough
having to deal with just one colour list. Adding a second one will make
it even harder to understand that code. My new idea now is to add the
few additional colours we need to the "System" colour list, the one
themes already override. Is this fine for everybody?

GSTheme already supports extra colors.

The API is -colorNamed:state:cache:

This is used for scroller slots (see GSThemeDrawing.m) and for thew color of a scrollview (NSScrollView.m)

I don't see any point in changing the system colors ... they can remain as they are for OSX compatibility, but for theming our own controls we can keep things simple by using the GSTheme API directly.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]