[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnustep-cvs] r29139 - in /libs/gui/trunk: ChangeLog Source/NSSlider

From: Eric Wasylishen
Subject: Re: [Gnustep-cvs] r29139 - in /libs/gui/trunk: ChangeLog Source/NSSliderCell.m
Date: Sat, 19 Dec 2009 15:19:09 -0700

Hi Fred,

On 2009-12-19, at 2:29 PM, Fred Kiefer wrote:

> The change to setMinValue: and setMaxValue: surely are correct and the
> addition of setObjectValue: is just great. What I don't understand is
> why the method setDoubleValue:,  setFloatValue: and setIntValue: had to
> be implemented. The default behaviour (calling setObjectValue:) should
> just do the right thing.

Ah, you're right, setDoubleValue:,  setFloatValue: and setIntValue: shouldn't
be necessary.

> Sadly this is not true for setStringValue:, where the current GNUstep
> implementation on NSCell has a short cut which doesn't call
> setObjectValue:. This should be corrected instead of having a separate
> implementation here.

Sounds good, I will look at fixing -[NSCell setStringValue:], and then we can
remove -[NSSliderCell setStringValue:]. 

> What should be the default value for isContinuous when the cell is just
> created? When we get that right we may not have to set that value when
> dearchiving, as it will get archived as action mask by the super class.

I just checked in F-Script on Snow Leopard:

> NSSliderCell new isContinuous
> NSActionCell new isContinuous
> NSCell new isContinuous

So maybe we can just add [self setContinuous: YES] to NSSliderCell's -init,
and remove my changes to NSSliderCell dearchiving?

> As for the commit access a simple mail to Adam should be sufficient to
> get that. A line in a commit comment wont help. Who is supposed to read
> that?
I'll send an email to Adam.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]