Re: [PATCH] Remove objc_mutex usage from gnustep-base

[Gregory Casamento]

Please fill out the attached form and send it to address@hidden and
address@hidden and they will send you a form to fill out for the
assignment.

Thanks, and welcome to the project!

GC

On Wed, Jan 20, 2010 at 1:09 PM, Niels Grewe <address@hidden> wrote:
> Hello all,
>
> attached is a small patch that replaces all objc_mutexes in gnustep-base
> with pthread_mutexes (save for the runtime mutex, of course). NSLock and
> friends already use pthreads and I don't think there is anything to be
> gained by sticking to the old runtime-threading layer in other places
> (the new runtime doesn't even export objc_mutex_(de)allocate() anymore).
> This also has the added benefit that (slightly faster) non-recursive
> mutexes can be used in a few places, where they're just protecting
> simple lookup or update operations on some table. As a downside, the
> GSAllocateMutexAt() function from GSObjCRuntime.h had to go (but, apart
> from the fact that using objc_mutexes shouldn't really be encouraged,
> nobody seems to be using it).
> I verified that the testsuite still passes for -base after the change
> and I didn't notice any problems in day-to-day usage. Still, I'd really
> appreciate somebody taking a closer look.
>
> I'd also like to ask about whom to contact regarding copyright
> assignment. I know that this is a rather insignificiant (and repetitive)
> contribution, so it might not be strictly needed, but just in case…
>
> kind regards,
>
>
> Niels
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.14 (GNU/Linux)
>
> iQEcBAEBAgAGBQJLV0bDAAoJEJl3lUkpjbg+a4kH/0EiAloUlES44Gm03UhmIS3B
> Qdmw+g1NfdXnOA32uqr9c/5cvZvKOqVeAZNVJMNkCXpKE6HkZlK8QgL5U3XPskCn
> IdyTqjHJasbPJ5AkyhBr7iyeVw0XuimQ0XRUpsw12XrRYppn31jDFsR8nJ76SvMD
> 15EUSvFgN7aVHz+aO9dSzkSlR4ri390C53Sj6qDfcHVivmxvsOya5YpVdmmat/9c
> tqbnMdXSSlmd5djjf/6LIcChdJkR0+gxUp9bzKVf35qBy2+RFGcesqoyeRquLM52
> nZUPkKeUaFu15z6h/UojL9W7D5TZpUpiJZ6CB2uFuS6mg7AvptxdR30yzlgEcrM=
> =ah2/
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnustep-dev
>
>



-- 
Gregory Casamento
Open Logic Corporation, Principal Consultant
## GNUstep Chief Maintainer
yahoo/skype: greg_casamento, aol: gjcasa
(240)274-9630 (Cell), (301)362-9640 (Home)

request-assign.future
Description: Binary data