Re: [Gnustep-cvs] r29500 - in /libs/gui/trunk: ChangeLog Source/NSToolbarItem.m

[Riccardo Mottola]

Fred,

sure, I discovered with a freely available open-source application 
(namely Grr, in GAP) that toolbar items did not work correctly. The 
current code in Grr yields a working and resizing toolbar on cocoa, but 
not on gnustep, where the last item after the flexible white space gets 
chopped off badly.

The "old" code of Grr worked on GNUstep and not on Cocoa...

Cocoa requires the min and max sizes of a toolbar item to be set if the 
toolbar item gets set a view (and the search field in Grr does so).

The old GNUstep code just assumed that if min and max width were the 
same then the item was flexible space, I think this was wrong since it 
doesn't allow to have resizable items apart from the space.

With my fix, the proper class is checked. The toolbar at least displays 
correctly and is usable!
Resizing is however not as smart as on the mac, since it does not take 
in account of min and max size at all!
In the whole toolbar code those sizes are not checked.

 I am trying to implement the smarter resizing code, I think I have the 
algorithm, but probably fail to correctly get the space to allocate. If 
I don't get a solution to, I'll share the patch with you.

Riccardo


Fred Kiefer wrote:
> Am 07.02.2010 19:41, schrieb Riccardo Mottola:
>    
> > Author: rmottola
> > Date: Sun Feb  7 19:41:04 2010
> > New Revision: 29500
> >
> > URL: http://svn.gna.org/viewcvs/gnustep?rev=29500&view=rev
> > Log:
> > use proper class check instead of quick and dirty size check for flexible space 
> > property
> >
> > Modified:
> >      libs/gui/trunk/ChangeLog
> >      libs/gui/trunk/Source/NSToolbarItem.m
> >      
> Could you please explain why you changed this? I had made the opposite
> change a while ago to allow people to define their own flexible spaced
> toolbar items. This was in response to bug report #26339. I never
> learned whether my changed helped or not. But this seems to be normal
> for GNUstep bug reports. For some time now I decided that when people
> stop complaining after a fix their problem is most likely solved.
> But your change should break thinks again.
>
>
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnustep-dev
>
>