gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnustep-cvs] r30407 - in /libs/gui/trunk: ChangeLog Source/NSApplic


From: Fred Kiefer
Subject: Re: [Gnustep-cvs] r30407 - in /libs/gui/trunk: ChangeLog Source/NSApplication.m
Date: Mon, 17 May 2010 19:39:38 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.9) Gecko/20100317 SUSE/3.0.4-1.1.1 Thunderbird/3.0.4

Am 17.05.2010 10:29, schrieb Gregory Casamento:
> Author: gcasa
> Date: Mon May 17 10:29:55 2010
> New Revision: 30407
> 
> URL: http://svn.gna.org/viewcvs/gnustep?rev=30407&view=rev
> Log:
>       * Source/NSApplication.m: Attempt to open files from the command
>       line, if possible in -finishLaunching.  This matches the behavior
>       seen on OpenStep and on Mac OS X/Cocoa.
> 
> Modified:
>     libs/gui/trunk/ChangeLog
>     libs/gui/trunk/Source/NSApplication.m

Hi Greg,

I believe this change does the wrong thing. If I understand correctly
what your code is trying to do, it loops over all the arguments to the
process, ignoring the ones that start with a "-", which most likely are
command switches, gathers them all up and then tries to open then.

This sounds fine until you realize that GNUstep gui already had some
command line argument processing. For example, we allow for files to get
printed and this wont be possible any more with your code.
The just open them all approach may improve things for people doing
simple things, but breaks stuff for everybody who knows about this
special features of GNUstep.

Fred



reply via email to

[Prev in Thread] Current Thread [Next in Thread]