gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnustep-cvs] r32880 - /libs/back/trunk/Source/cairo/CairoFontEnumer


From: Quentin Mathé
Subject: Re: [Gnustep-cvs] r32880 - /libs/back/trunk/Source/cairo/CairoFontEnumerator.m
Date: Tue, 19 Apr 2011 00:47:16 +0200

Le 18 avr. 2011 à 21:09, Eric Wasylishen a écrit :

> Hey Quentin,
> Fred and I discussed this and he didn't like the use of -respondsToSelector: 
> and -performSelector: given that the list of methods being called is fixed at 
> compile time. I agree with him; if we left the code as it was, I could have 
> made a typo in a method name that would go undetected until a particular type 
> of font descriptor came along. I also don't like macros but I think they're 
> simple enough in this case.

ok, this makes sense :-)

Quentin.

> On 2011-04-18, at 6:43 AM, Quentin Mathé wrote:
> 
>> Hey Eric,
>> 
>> Le 18 avr. 2011 à 00:29, Eric Wasylishen a écrit :
>> 
>>> Author: ericwa
>>> Date: Mon Apr 18 00:29:18 2011
>>> New Revision: 32880
>>> 
>>> URL: http://svn.gna.org/viewcvs/gnustep?rev=32880&view=rev
>>> Log:
>>> back/cairo: CairoFontEnumerator.m: Replace -handleKey:selector:valueClass: 
>>> and -handleKey:selector: methods with macros.
>>> 
>>> Modified:
>>>  libs/back/trunk/Source/cairo/CairoFontEnumerator.m
>> 
>> Just curious… What is the motivation behind this change, given that macros 
>> are harder to reason about and debug than methods? Is this a performance 
>> improvement?
>> 
>> Cheers,
>> Quentin.
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]