[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Gorm is broken

From: Riccardo Mottola
Subject: Re: Gorm is broken
Date: Tue, 03 May 2011 18:01:58 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20110420 SeaMonkey/2.0.14


fixing the images is incorrect I think. 96DPI and 72DPI are both "acceptable" values for screen displays. There is actually no real standard and screens have a varying resolution. Thus 72 and 96 DPIs are just custom values. Traditionally, Mac saved images with no "explicit" resolution as 72dpi and windows tends to use 96dpi.

I think your patch is wrong in concept: no developer would expect their button or any other gui element to be resized according to the display resolution. A pixel is a pixel in that case.


Gregory Casamento wrote:
Hey Eric,

I saw the commit changing things to 72DPI. It does seem to correct the issue. I believe we'll have to do with same for some of the apps in GAP as well since the DPI settings there are wrong as well for a few of them. :)


On May 1, 2011, at 7:00 PM, Eric Wasylishen wrote:

Hi Gregory,
I just noticed the scaled down icons as well. It should be fixed now.

With r32920 and r32916 I read the DPI metadata in TIFF's and PNG's, and use it to calculate the dimensions of images in points. Some of the included GNUstep images had their DPI metadata set to 96, which is why they were being scaled down, so I set these to 72.

btw, some images are getting slightly blurred, at least with the cairo backend (the scroller arrows, the "home" button in file dialogs.) I'm not sure why that is, but it's likely one of my recent image changes, and I'll look into it.


On 2011-05-01, at 4:06 PM, Gregory Casamento wrote:

I'm seeing the icons scaled down on some apps.   Could this be because
of this change as well?

On Sun, May 1, 2011 at 1:40 PM, Germán Arias <address@hidden <mailto:address@hidden>> wrote:
OK, the problem was that I don't recompile the palette "Boxes". Now
works, thanks.

On sáb, 2011-04-30 at 23:35 -0600, Eric Wasylishen wrote:
Assuming you are running trunk of everything, see if undoing my change r 32895 makes the problem go away. The command to do that is "svn merge --change -32895 Source/NSImage.m" from the gui directory. In that revision I removed some code in -compositeToPoint: which cached the image.

I'm running trunk of base/gui/back and gorm and they seems to work for me.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]