Re: [Gnustep-cvs] r33150 - /libs/gui/trunk/Source/NSMenu.m

[Fred Kiefer]

On 27.05.2011 16:08, David Chisnall wrote:
> Author: theraven
> Date: Fri May 27 16:08:35 2011
> New Revision: 33150
>
> URL: http://svn.gna.org/viewcvs/gnustep?rev=33150&view=rev
> Log:
> Don't create a zone in GC mode (detected at run time).  This avoids a warning
> when starting GUI apps in GC mode, but should have no real effect on
> functionality.
>
> Note: this zone seems to have been created for OpenStep compatibility, but then
> we don't actually use it anywhere.  The Cocoa docs say that this is 'The zone
> from which NSMenu objects should be allocated', but we allocate NSMenu objects
> from the default malloc zone.
>
> Fred: I think the correct thing to do here is probably to just return
> NSDefaultMallocZone() from +menuZone in all modes.  Can you take a look and
> see?
>
>
> Modified:
>      libs/gui/trunk/Source/NSMenu.m

Currently you are surely right. But I am not sure whether this is the 
best thing we could do. Maybe it is worthwhile to have a separate zone 
here, it would be really simple to implement that bit. I just don't see 
the point of it. You don't create that many menus in an application, do you?
Having a separate zeone for NSEvent would make a lot more sense to me.