Re: [Gnustep-cvs] r33621 - in /libs/base/trunk: Headers/Foundation/ Headers/GNUstepBase/ Source/ Source/Additions/ Source/unix/ Tests/base/NSHashTable/ Tests/base/NSPointerArray/

[Fred Kiefer]

Once again you changes stop me from compiling base.

The last time you made a change to preface.h.in I had problem because 
there was a copy of preface.h in an old directory. But this time 
everything is different. A few days ago Richard replaced all of the 
usages of preface.h with GSConfig.h. You should have put your additions 
in there and not scattered references to the obsolete file in the code 
(OK, just on in NSAssertionHandler, but that is bad enough). On the 
other hand, Richard should have removed preface.h.in to prevent you from 
doing so :-(

I will try to fix up that mess, but it would be great if the two of you 
check that I didn't make it even bigger.

Fred

On 24.07.2011 15:09, David Chisnall wrote:
> Author: theraven
> Date: Sun Jul 24 15:09:22 2011
> New Revision: 33621
>
> URL: http://svn.gna.org/viewcvs/gnustep?rev=33621&view=rev
> Log:
> Lots of little fixes to make -base compile with -Werror (now builds without 
> warnings).
>
> Richard: I'm unsure about three of these, which were fixes in memset() calls in:
> - NSConcreteMapTable.m
> - NSConcreteHashTable.m
> - Additions/NSData+GNUstepBase.m
>
> Please can you check them?  I think they are intended to zero the entire object
> (rather than the first word), but the lack of comments makes me unsure.
>
> Most changes were just tweaks to variable types.  I've also removed some dead 
> code from NSInvocation.  This was small group of things that were marked for 
> internal use only, but not actually referenced in the code anywhere.
>
> Other improvements:
>
> - NSArray / NSDictionary fixed up to use the 10.7 (ARC-friendly) prototypes.
> - getObjects:andKeys: implemented for NSDictionary (10.5 method)
> - NSPointerArray and NSHashTable now properly support weak objects.
> - Tests for weak objects in collections.
>
>
> Added:
>      libs/base/trunk/Tests/base/NSHashTable/weak.m
>      libs/base/trunk/Tests/base/NSPointerArray/weak.m
> Modified:
>      libs/base/trunk/Headers/Foundation/NSArray.h
>      libs/base/trunk/Headers/Foundation/NSDictionary.h
>      libs/base/trunk/Headers/Foundation/NSEnumerator.h
>      libs/base/trunk/Headers/Foundation/NSInvocation.h
>      libs/base/trunk/Headers/GNUstepBase/GSFileHandle.h
>      libs/base/trunk/Headers/GNUstepBase/GSIMap.h
>      libs/base/trunk/Headers/GNUstepBase/preface.h.in
>      libs/base/trunk/Source/Additions/GCDictionary.m
>      libs/base/trunk/Source/Additions/GSInsensitiveDictionary.m
>      libs/base/trunk/Source/Additions/GSLock.m
>      libs/base/trunk/Source/Additions/NSData+GNUstepBase.m
>      libs/base/trunk/Source/GSArray.m
>      libs/base/trunk/Source/GSDictionary.m
>      libs/base/trunk/Source/GSInvocation.h
>      libs/base/trunk/Source/NSArray.m
>      libs/base/trunk/Source/NSAssertionHandler.m
>      libs/base/trunk/Source/NSCharacterSet.m
>      libs/base/trunk/Source/NSConcreteHashTable.m
>      libs/base/trunk/Source/NSConcreteMapTable.m
>      libs/base/trunk/Source/NSConcretePointerFunctions.h
>      libs/base/trunk/Source/NSConnection.m
>      libs/base/trunk/Source/NSCountedSet.m
>      libs/base/trunk/Source/NSData.m
>      libs/base/trunk/Source/NSDate.m
>      libs/base/trunk/Source/NSDebug.m
>      libs/base/trunk/Source/NSDictionary.m
>      libs/base/trunk/Source/NSDistantObject.m
>      libs/base/trunk/Source/NSHost.m
>      libs/base/trunk/Source/NSIndexPath.m
>      libs/base/trunk/Source/NSInvocation.m
>      libs/base/trunk/Source/NSKeyValueObserving.m
>      libs/base/trunk/Source/NSPointerArray.m
>      libs/base/trunk/Source/NSProcessInfo.m
>      libs/base/trunk/Source/NSPropertyList.m
>      libs/base/trunk/Source/NSTimeZone.m
>      libs/base/trunk/Source/NSValue.m
>      libs/base/trunk/Source/unix/NSStream.m