gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

NSImage _clearFileTypeCaches


From: Philippe Roussel
Subject: NSImage _clearFileTypeCaches
Date: Tue, 10 Jan 2012 21:49:59 +0100

Hi,

Isn't the following patch needed for the code in +imageFileTypes and
friends to rebuild the arrays when needed ? Those methods compare the
arrays' pointers with nil and I think RELEASE doesn't affect nil to its
argument.

Index: Source/NSImage.m
===================================================================
--- Source/NSImage.m    (révision 34482)
+++ Source/NSImage.m    (copie de travail)
@@ -1812,10 +1812,10 @@
     
 + (void) _clearFileTypeCaches: (NSNotification*)notif
 {
-  RELEASE(imageUnfilteredFileTypes);
-  RELEASE(imageFileTypes);
-  RELEASE(imageUnfilteredPasteboardTypes);
-  RELEASE(imagePasteboardTypes);
+  DESTROY(imageUnfilteredFileTypes);
+  DESTROY(imageFileTypes);
+  DESTROY(imageUnfilteredPasteboardTypes);
+  DESTROY(imagePasteboardTypes);
 }
 
 + (void) _themeDidActivate: (NSNotification *)notif

Philippe





reply via email to

[Prev in Thread] Current Thread [Next in Thread]