gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: some NSInteger to NSUinterger changes in -base


From: Fred Kiefer
Subject: Re: some NSInteger to NSUinterger changes in -base
Date: Mon, 09 Apr 2012 22:29:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0

This change looks fine to me, please go ahead and apply it.

Fred

On 09.04.2012 17:58, Sebastian Reitenbach wrote:
Hi,

while looking at latest release compilation warnings on OpenBSD amd64, I found 
that some of the changes made after the release don't seem to be right. NSArray 
count or indexOfObject return NSUInteger and also NSRange.location is 
NSUInteger, but the variables were changed from int to NSInteger. I think they 
should be NSUInteger.

is it OK when I commit the patch below?

Sebastian


Index: Tools/make_strings/StringsFile.m
===================================================================
--- Tools/make_strings/StringsFile.m    (revision 34987)
+++ Tools/make_strings/StringsFile.m    (working copy)
@@ -127,7 +127,7 @@
      NSMutableArray *update_list=[[NSMutableArray alloc] init];
      NSArray *lines;
      NSString *l;
-    NSInteger i,c,pos;
+    NSUInteger i,c,pos;        
      NSMutableDictionary *dummy_entries=[[NSMutableDictionary alloc] init];

      NSMutableString *user_comment=[[NSMutableString alloc] init];
Index: Tools/pl.m
===================================================================
--- Tools/pl.m  (revision 34987)
+++ Tools/pl.m  (working copy)
@@ -39,7 +39,7 @@
    NSFileHandle *fileHandle = nil;
    NSProcessInfo *processInfo = [NSProcessInfo processInfo];
    NSArray *arguments = [processInfo arguments];
-  NSInteger outputIndex = 0;
+  NSUInteger outputIndex = 0;

    // insert your code here
    outputIndex = [arguments indexOfObject: @"-output"];
@@ -94,7 +94,7 @@
    NSFileHandle *fileHandle = nil;
    NSProcessInfo *processInfo = [NSProcessInfo processInfo];
    NSArray *arguments = [processInfo arguments];
-  NSInteger inputIndex = 0;
+  NSUInteger inputIndex = 0;

    // insert your code here
    inputIndex = [arguments indexOfObject: @"-input"];




reply via email to

[Prev in Thread] Current Thread [Next in Thread]