On Wed, Feb 20, 2013 at 10:24 AM, Fred Kiefer
<address@hidden> wrote:
We don't add another timer here. The code just uses the same timer for a different runloop mode. This should allow the existing invalidation code to handle the timer correctly.
>From your comment I understand that you don't know too much details about our timer implementation. Let me state one point why I am reluctant to commit this change without comments from Richard or anybody else who understands that implementation: Some time ago we had a long standing bug in base that resulted in timers that were added for two modes not being handled correctly. There is a comment in the code now of this being fixed.
Even though the change in gui looks completely harmless, it could result trigger a bug somewhere else.
Any downsides to having two timers, then, aside from uglier code? At least for this release.