Re: [PATCH 18/21] Added support for libdispatch main queue in the main run loop.

[Richard Frith-Macdonald]

On 1 Mar 2013, at 18:15, Jean-Charles BERTIN wrote:

> Hmmm sorry but its clearly none of these solutions that will fix the
> problem: if context watchers is empty the run loop will never execute
> -[GSRunLoopCtxt pollUntil:within:]!
> 
> So I suggest an another patch to fix this.


Adding support for linking libdispatch into the run loop sounds like a good 
idea,  but I'm having some trouble sorting this out ... you seem to be doing a 
patch on a patch on a patch or something like that, and it's hard to see from 
all the stuff you've posted, what is what.

Could you please try to put together a single patch for the changes you think 
are needed (and only those changes)  for libdispatch.

Please see the guidelines for this on the wiki for this 
(http://mediawiki.gnustep.org/index.php/Report_Bugs)

In fact, I guess this might be split into two stages ... the first, smaller 
patch, to change configure.ac and the cofig.h.in and base.make.in files to 
detect the presence/usability of libdispatch (would we only consider it usable 
if we had block support?), and the second to conditionally include libdispatch 
into the runloop, and to implement the testcases to demonstrate that the 
integration works and that it doesn't break things.