Re: NSSavePanel test file fails to build

[Wolfgang Lux]

Fred Kiefer wrote:

> On 07.03.2013 17:35, Quentin Mathé wrote:
>> Le 7 mars 2013 à 16:10, Richard Frith-Macdonald a écrit :
>> 
>>> On 7 Mar 2013, at 14:52, Quentin Mathé wrote:
>>> 
>>>> I don't understand why setDelegate_reload.m isn't built.
>>> 
>>> Try looking at the log file (shouuld be tests.log) in which the error 
>>> messages should tell you.
>>> 
>>>> I tried to cd into gui/NSSavePanel/ and type 'make' here, but it then 
>>>> complains about not being able to find Testing.h.
>>>> I tried the same in the NSBezierPath directory directory, and I got a 
>>>> similar error about ObjectTesting.h missing.
>>>> 
>>>> Is my approach correct to build a single test directory? I looked for some 
>>>> documentation about the TestFramework, but I couldn't find any in GNUstep 
>>>> Make… May be I looked at the wrong place.
>>> 
>>> You certainly must have looked in the wrong place ... you need to look in 
>>> the TestFramework subdirectory for documentation on it (and examples).
>>> In any case, doing 'gnustep-tests --help' should have told you that you can 
>>> also do 'gnustep-tests --documentation'
>> 
>> ok thanks :-) I looked at test-tool.make and inside the Documentation 
>> directory, but I missed the TestFramework directory.
> 
> Most likely it is the @defs() statement that is causing you trouble. We 
> really need to rewrite this tests here to be black box tests.
> As you can see fro the testHopeful = YES; in the code, there is one test that 
> checks for an actual problem in GNUstep that needs fixing and it is something 
> that could not be tested via a black box test on the delegate. No idea, what 
> we should do here. Maybe turn this into a manual test that would be part of 
> GSTest?

I don't see how you could turn this into a black box test, but you could at 
least get rid of the @defs by adding a NSSavePanel category to the test program 
with a single method
- (NSBrowser *)browser { return _browser; }

Wolfgang