Re: Implementing NSString getBytes

[Stefan Bidi]

On Wed, Jun 12, 2013 at 4:12 PM, Fred Kiefer <address@hidden> wrote:

That code in CoreBase really looks quite nice. We should try to get more shared code between base and CoreBase, this could be a very good example. Of course with iconv as fallback when ICU isn't available and perhaps even a fallback for missing iconv. (BTW the UConverter element in the structure _str_encoding is never used and should be removed)

Yes, I've noticed that, as well.  I have this modification on my local copy but haven't committed it due to lack of time to build and test.

On 09.06.2013 20:19, Stefan Bidi wrote:

I'm not too familiar with GSFromUnicode(), but couldn't you treat this
function in the same way that CoreBase treats ucnv_fromUnicode()?  That is,
pass the buffer into GSFromUnicode() with GSUniStrict option.  If it
returns NO, adjust the src and use NULL for dst.  Would that work?

That said, I think it would be a good idea if the function you came up with
would have the same signature as GSStringEncodingFromUnicode() in
corebase.  I'd like to one day be able to share more code between the two
projects and GSStringEncodingFromUnicode() already supports that method's
requirements.

_______________________________________________
Gnustep-dev mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/gnustep-dev