gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

CoreBase and GSVersionMacros


From: Ivan Vučica
Subject: CoreBase and GSVersionMacros
Date: Wed, 3 Jul 2013 12:34:34 +0100

Hello,

In a minute or so, I'll be committing a change for the section that defines OS X version macros in CFBase.h and replacing it with inclusion GSVersionMacros.h. The comment explicitly says that this inclusion would break clang and Windows; I've tested with a trunk version of Clang 3.4, and there seem to be no issues.

The reason for this change is that constants no longer match what's in Base, and there are some ugly warnings.

Stefan, I'm interested what the bug was?

And, if anyone's CoreBase breaks horribly after this change, here's what I'm changing:

------------------8<------------
/* FIXME: These macros are defined here to work around an issue with including
 * GNUstepBase/GSVersionMacros.h when compiling with clang or on Windows.
 */
#ifndef MAC_OS_X_VERSION_10_0
#define MAC_OS_X_VERSION_10_0 100000
#define MAC_OS_X_VERSION_10_1 100100
#define MAC_OS_X_VERSION_10_2 100200
#define MAC_OS_X_VERSION_10_3 100300
#define MAC_OS_X_VERSION_10_4 100400
#define MAC_OS_X_VERSION_10_5 100500
#define MAC_OS_X_VERSION_10_6 100600
#define MAC_OS_X_VERSION_10_7 100700
#endif /* MAC_OS_X_VERSION_10_0 */

#define MAC_OS_X_VERSION_MAX_ALLOWED 100700
----------------8<-------------------

into this:

---------------8<---------------
#include <GNUstepBase/GSVersionMacros.h>
----------------8<--------------

--
Ivan Vučica - address@hidden


reply via email to

[Prev in Thread] Current Thread [Next in Thread]