Re: GNUstep don't load images of current theme.

[Eric Wasylishen]

Hi Greg,

There were several things we tried to do:

- make a clearly defined set of image names (listed in Headers/Additions/GNUstepGUI/GSTheme.h ) for themes to override. Currently we just have GSSwitch and GSRadio listed there. 

- make the image names for themes to override describe what the image is used for (GSMenuArrow rather than common_3DArrowRight)

- use a standard formula for choosing the names of alternate image state (e.g. GSRadio, GSRadioSelected, GSRadioDisabled, GSRadioDisabledSelected).

The change that breaks existing themes is that the images now have to be listed in the theme's plist in a GSThemeImages dictionary. Perhaps requiring this is not the way to go. 

Themes now use the mapping file, btw. :)  +[imageNamed: aName] always looks up aName in the mapping file, and uses the mapped name to call +[NSImage _pathForImageNamed:] and stores the resulting image in the nameDict under the mapped name.The intention is that if a mapping exists in nsmapping.strings, the image will always be stored in nameDict under the mapped name.

Eric

P.S., Quentin, it seems the Aristo2.theme's theme info plist is not committed in etoile svn. Could you commit that so we have a minimal example of the new theme format?

On 2013-07-16, at 6:11 PM, Gregory Casamento <address@hidden> wrote:

Eric,

The theme image replacement code was buggy, but it worked better than nothing.  So, what you're saying is, we now have nothing.   I'm not sure I see how this improves the situation.

Is it possible to put some code in to replace this which will perform a similar function?   Also, the issue what you were seeing where it needed to have several names was, likely, due to the fact that themes do not read the mappings file.

GC

On Tue, Jul 16, 2013 at 4:12 AM, Riccardo Mottola <address@hidden> wrote:

Hi,

just as reference, these are the images currently part of the Sleek theme of CVS, which is the most comprehensive theme at the moment:

$ ls -p Sleek.theme/Resources/ThemeImages/
CVS/
common_3DArrowRight.tiff
common_Desktop.tif
common_Dimple.tif
common_DimpleHoriz.tif
common_DocsFolder.tif
common_DownloadFolder.tif
common_Folder.tif
common_GSFolder.tif
common_Home.tif
common_HomeDirectory.tif
common_ImageFolder.tif
common_LibraryFolder.tif
common_Mount.tif
common_MusicFolder.tif
common_Nibble.tif
common_RadioOff.tif
common_RadioOn.tif
common_Right.tif
common_Root_PC.tif
common_SwitchOff.tif
common_SwitchOn.tif
common_ToolbarCustomizeToolbarItem.tiff
common_Unknown.tif
common_UnknownApplication.tiff
common_UnknownTool.tif
common_Unmount.tif
common_outlineCollapsed.tif
common_outlineExpanded.tiff
common_outlineUnexpandable.tiff
common_ret.tiff
common_retH.tiff
outlineCollapsed.tiff

The only one that looks "out of place" is outlineCollapsed which is present twice. The theme is created and maintained in Thematic. The fact that they are named common_ * has already been matter of discussion and "I lost" :)

Riccardo

_______________________________________________
Gnustep-dev mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/gnustep-dev

--
Gregory Casamento
Open Logic Corporation, Principal Consultant
yahoo/skype: greg_casamento, aol: gjcasa
(240)274-9630 (Cell)
http://www.gnustep.org
http://heronsperch.blogspot.com