Re: NSSavePanel fragile ABI - do we care?

[Fred Kiefer]

At the current state of gui breaking the ABI is fine, we do it with
almost every release. The only thing we should think about is whether we
want to make a 0.23.2 release of gui before that.

I can see what you need the _completionHandler ivar for, but what is the
purpose of the _modelessWindowController?

One other way to implement this would be to extend the sheet code in
NSApplication. At the moment sheets are just modal windows.
One simple way would be to implement a sheet delegate class that just
executes the completion block. In the long run, the other way around,
implementing sheet delegates with completion blocks will be more
elegant, but for now this could do.

Fred

On 11.08.2013 02:17, Gregory Casamento wrote:
> I would defer to Fred on this one.   He's currently on holiday, but should
> be back soon.
> 
> GC
> 
> 
> On Sat, Aug 10, 2013 at 9:55 AM, Luboš Doležel <address@hidden> wrote:
> 
>> Hi,
>>
>> I'm adding two methods using blocks:
>>
>> - (void) beginSheetModalForWindow:(NSWindow *)window
>>                 completionHandler:(GSSavePanelCompletionHandler)handler;
>> - (void) beginWithCompletionHandler (GSSavePanelCompletionHandler)handler;
>>
>> into NSSavePanel. For the latter, I need to add two ivars
>>
>> GSSavePanelCompletionHandler _completionHandler;
>> NSWindowController *_modelessWindowController;
>>
>> since its modeless and returns immediately.
>>
>> Should I add indirection not to break fragile ABI derived classes, or do
>> you think it's not needed for this class?