Re: gnustep-make problem with tools and resource bundles Re: Next release?

[Fred Kiefer]

Sorry for not replying earlier. I am no expert on GNUstep make, but your
change seems valid to me. The worst that should result from it is a left
over Resource folder in the build directory.
You could limit your change to the case where GNUSTEP_BUILD_DIR is equal
to "." in all other cases the old code seems fine. But then this
condition may be hard to check when different notations for the same
directory are possible.

Fred

On 22.12.2013 08:43, Sebastian Reitenbach wrote:
> Ping!
>  
> On Thursday, December 12, 2013 07:23 CET, "Sebastian Reitenbach" 
> <address@hidden> wrote: 
>> I have a problem with GNUstep make. With the ImpersonatorToolKit, I have
>> a Tool with additional Resource files that need to get installed. So I have
>> them in the Resources subdirectory, and in GNUmakefile I have set:
>>
>> ImpersonatorToolKit_HAS_RESOURCE_BUNDLE=yes 
>>
>> then
>> make && make install
>>  works well and as expected, but trying to do:
>> make clean
>>
>> completely wipes the Resources directory from the disk. This is only annoying
>> when you have the stuff in SVN or elsewhere, but may wipe important stuff 
>> before
>> you have it in a RCS ;)
>>
>> The patch below fixes the problem for me, only deleting the subdirectory
>> that gets created when calling make .
>> Before I came up with the patch as it is currently below, I stumbled about
>> the GNUSTEP_SHARED_BUNDLE_RESOURCE_PATH variable that gets
>> filled in Instance/tool.make, but trying to use that variable, its empty at
>> the make clean stage, so didn't work.
>> Is that patch the right approach to the problem? If so, I'd like to go on
>> and commit it, otherwise I'm open for other suggestions.
>>
>>
>>
>> cheers,
>> Sebastian
>>
>>
>>  
>>  $OpenBSD$
>> --- Master/tool.make.orig    Wed Dec 11 07:24:02 2013
>> +++ Master/tool.make Wed Dec 11 07:25:46 2013
>> @@ -41,7 +41,7 @@ $(GNUSTEP_BUILD_DIR)/Resources:
>>  # On distclean, we want to efficiently wipe out the Resources/
>>  # directory.
>>  internal-clean::
>> -    rm -rf $(GNUSTEP_BUILD_DIR)/Resources
>> +    rm -rf $(MAYBE_GNUSTEP_BUILD_DIR_RESOURCES)/$(TOOL_NAME)
>>  else
>>  MAYBE_GNUSTEP_BUILD_DIR_RESOURCES =
>>  endif