gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problem with object sender in -insertTab:


From: Fred Kiefer
Subject: Re: Problem with object sender in -insertTab:
Date: Fri, 24 Jan 2014 11:43:32 +0100

Thank you for beating me on this :-)
Your change looks more correct than my suggestion.

Fred

On the road

Am 24.01.2014 um 10:11 schrieb Wolfgang Lux <address@hidden>:

> 
>> Am 23.01.2014 um 09:53 schrieb Fred Kiefer <address@hidden>:
>> 
>> I think the problem is in NSTextView doCommandBySelector: there we should 
>> use the form of performSelector that has an additional argument. The only 
>> argument we can use here is self, which might not be what you expect, but it 
>> is still better than having a corrupt stack. I will try to fix this tomorrow.
> 
> Well, you can (and should) use nil instead of self. This is what Apple's 
> documentation for the NSResponder class says and (according to a quick test 
> in a program where I have overwritten the -insertTab: method) also what 
> Apple's AppKit is doing. I just committed that change.
> 
> Wolfgang



reply via email to

[Prev in Thread] Current Thread [Next in Thread]