[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GWorkspace file operation pause/stop problems

From: Riccardo Mottola
Subject: Re: GWorkspace file operation pause/stop problems
Date: Wed, 10 Sep 2014 16:56:02 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 SeaMonkey/2.26.1


Riccardo Mottola wrote:
Hi Wofgang,

disegard my previous patch. I don't know why it did hang for me, it did only on clang/libobjc2, on another computer it worked. Still, it was buggy in concept. A resume after pause had the "progress bar" restart and jump. The fact is that most of the information of the status is held in the executor, which, on pause, we loose. Besides from the processed files, which I communicated back to the master, we also have information such about the total vs. current number of files.
On pause, we need to communicate it all back.

I added thus also the processed files in the caller, as well as adding a parameter to calculateNumFiles to skip the calculation and just resume. What do you think? does it work for me? It works for me in a simple case e.g. copying 10 files (the only operatio supported is copy right now).

What is not working? if there are "duplicated" files, that is the panel comes up, not only the check is performed again, but the total is calculated wrongly again. Ideas? One idea would be to store the operation (overwrite, copy, skip) in the caller and pass it to the executor again.

At the end it was a matter of saving the "onlyOlder" property and cleaning up the code a little more.

I commited the patch after having it extended from copy to other operations.

I hope the code works better for you all now, it appears to me so!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]